Issue 7794046: Avoid crash in createDevice() if it is called on a Display that did not initialize (e.g. Direct3DCr…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7794046: Avoid crash in createDevice() if it is called on a Display that did not initialize (e.g. Direct3DCr…

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by baustin

Modified:
11 years, 1 month ago

Reviewers:
apatrick1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Avoid crash in createDevice() if it is called on a Display that did not initialize (e.g. Direct3DCreate9 returned NULL). Fixed compiler warning.

Patch Set 4 : #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/libEGL/Display.cpp	View	1 2 3	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

apatrick1

https://codereview.appspot.com/7794046/diff/4001/src/libEGL/Display.cpp File src/libEGL/Display.cpp (right): https://codereview.appspot.com/7794046/diff/4001/src/libEGL/Display.cpp#newcode482 src/libEGL/Display.cpp:482: return error(EGL_BAD_ALLOC, false); I think this should generate EGL_NOT_INITIALIZED.

11 years, 1 month ago (2013-03-19 18:57:07 UTC) #2

baustin

11 years, 1 month ago (2013-03-19 20:53:55 UTC) #3

baustin

Yes, please. I've got another change in Surface.cpp that I'll send out in a few ...

11 years, 1 month ago (2013-03-19 21:05:50 UTC) #5

apatrick1

11 years, 1 month ago (2013-03-19 21:29:13 UTC) #6

Landed at r2000: https://codereview.appspot.com/7494048/

Expand All Messages | Collapse All Messages