Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 7777045: Add support for go version of get_service.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by bac
Modified:
11 years ago
Reviewers:
bcsaller, mp+153140, jeff.pihach
Visibility:
Public.

Description

Add support for go version of get_service. https://code.launchpad.net/~bac/juju-gui/get-service/+merge/153140 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add support for go version of get_service. #

Total comments: 8

Patch Set 3 : Add support for go version of get_service. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -14 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/go.js View 1 2 8 chunks +69 lines, -14 lines 0 comments Download
M test/test_env_go.js View 1 2 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
11 years ago (2013-03-13 14:00:47 UTC) #1
jeff.pihach
LGTM land with trivial changes. Thanks! https://codereview.appspot.com/7777045/diff/2001/app/store/env/go.js File app/store/env/go.js (right): https://codereview.appspot.com/7777045/diff/2001/app/store/env/go.js#newcode357 app/store/env/go.js:357: * @method expose ...
11 years ago (2013-03-13 17:40:37 UTC) #2
bcsaller
LGTM w/previously mentioned doc changes. Thanks for the branch. I made some comments on the ...
11 years ago (2013-03-13 17:46:26 UTC) #3
bac
Changes made. Thanks for the reviews. https://codereview.appspot.com/7777045/diff/2001/app/store/env/go.js File app/store/env/go.js (right): https://codereview.appspot.com/7777045/diff/2001/app/store/env/go.js#newcode357 app/store/env/go.js:357: * @method expose ...
11 years ago (2013-03-13 18:11:02 UTC) #4
bac
11 years ago (2013-03-13 18:27:38 UTC) #5
*** Submitted:

Add support for go version of get_service.

R=jeff.pihach, bcsaller
CC=
https://codereview.appspot.com/7777045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b