Issue 77580045: code review 77580045: ogle: add name->PC lookup for functions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 77580045: code review 77580045: ogle: add name->PC lookup for functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by r

Modified:
10 years, 1 month ago

Reviewers:
nigeltao

CC:
nigeltao

Visibility:
Public.

Description

ogle: add name->PC lookup for functions The symbol table we can access has functions but no data, so until that is resolved we can only evaluate function names.

Patch Set 2 : diff -r d44ba9529c0f https://code.google.com/p/ogle #

Total comments: 1

Patch Set 3 : diff -r d44ba9529c0f https://code.google.com/p/ogle #

Patch Set 4 : diff -r d44ba9529c0f https://code.google.com/p/ogle #

Patch Set 5 : diff -r d44ba9529c0f https://code.google.com/p/ogle #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -6 lines)			Patch
M	cmd/ogleproxy/main.go	View	1 2 3 4	1 chunk	+4 lines, -5 lines	0 comments	Download
M	program/client/client.go	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	program/program.go	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	program/proxyrpc/proxyrpc.go	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	program/server/server.go	View	1 2	2 chunks	+102 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle

10 years, 1 month ago (2014-03-19 05:05:33 UTC) #1

nigeltao

LGTM. https://codereview.appspot.com/77580045/diff/20001/program/server/server.go File program/server/server.go (right): https://codereview.appspot.com/77580045/diff/20001/program/server/server.go#newcode55 program/server/server.go:55: // This file is copied from $GOROOT/src/cmd/addr2line/main.go. s/file/function/

10 years, 1 month ago (2014-03-20 04:52:02 UTC) #2

10 years, 1 month ago (2014-03-20 05:52:23 UTC) #3

*** Submitted as https://code.google.com/p/ogle/source/detail?r=24d35d6d19c9 ***

ogle: add name->PC lookup for functions
The symbol table we can access has functions but no data, so until
that is resolved we can only evaluate function names.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/77580045

Expand All Messages | Collapse All Messages