Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(729)

Issue 7752044: Support add_relation in go env, with tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by teknico
Modified:
11 years ago
Reviewers:
frankban, matthew.scott, mp+154014
Visibility:
Public.

Description

Support add_relation in go env, with tests. https://code.launchpad.net/~teknico/juju-gui/support-add-relation-in-go-env/+merge/154014 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Support add_relation in go env, with tests. #

Total comments: 8

Patch Set 3 : Support add_relation in go env, with tests. #

Total comments: 27

Patch Set 4 : Support add_relation in go env, with tests. #

Patch Set 5 : Support add_relation in go env, with tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -39 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/go.js View 1 2 3 3 chunks +72 lines, -3 lines 0 comments Download
M app/views/topology/relation.js View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M test/test_env_go.js View 1 2 3 2 chunks +99 lines, -26 lines 0 comments Download
M test/test_env_python.js View 1 2 5 chunks +91 lines, -8 lines 0 comments Download

Messages

Total messages: 11
teknico
Please take a look.
11 years ago (2013-03-19 09:16:47 UTC) #1
teknico
Please take a look.
11 years ago (2013-03-19 14:44:46 UTC) #2
frankban
This branch looks good, thanks Nicola. I just have some doubts, especially on the add_relation ...
11 years ago (2013-03-19 17:08:21 UTC) #3
teknico
Added the logic needed to make the Go env. behave as the calling code expects. ...
11 years ago (2013-03-22 12:47:03 UTC) #4
teknico
Please take a look.
11 years ago (2013-03-22 12:51:29 UTC) #5
matthew.scott
LGTM with minors. Thanks for the additional tests in Python-land, too. https://codereview.appspot.com/7752044/diff/10001/app/store/env/go.js File app/store/env/go.js (right): ...
11 years ago (2013-03-22 16:03:47 UTC) #6
frankban
Thanks Nicola, you also fixed the remove_relation call. Also thanks for adding tests for the ...
11 years ago (2013-03-22 16:05:47 UTC) #7
teknico
Thanks for both reviews. I hope I managed to explain myself on a number of ...
11 years ago (2013-03-22 16:54:53 UTC) #8
teknico
Please take a look.
11 years ago (2013-03-22 16:56:14 UTC) #9
frankban
On 2013/03/22 16:54:53, teknico wrote: > https://codereview.appspot.com/7752044/diff/10001/app/store/env/go.js#newcode582 > app/store/env/go.js:582: endpoint_a: endpoint_a, > frankban wrote: > ...
11 years ago (2013-03-22 17:13:38 UTC) #10
teknico
11 years ago (2013-03-22 17:25:45 UTC) #11
*** Submitted:

Support add_relation in go env, with tests.

R=frankban, matthew.scott
CC=
https://codereview.appspot.com/7752044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b