Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(948)

Issue 77480043: Fix two bugs relating to --isolated missing and .isolate file being copied. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by M-A
Modified:
11 years, 4 months ago
Reviewers:
vadimsh
CC:
swarming-eng_googlegroups.com, csharp+cc_chromium.org, vadimsh+cc_chromium.org
Base URL:
https://code.google.com/p/swarming.client@master
Visibility:
Public.

Description

Fix two bugs relating to --isolated missing and .isolate file being copied. Using isolate.py run without --isolated would crash. If a user copy (and not move) a .isolate file from one location to another, silently drop the saved state instead of throwing an exception. Add unit test for both issues. R=vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=client&r=8472efa

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -7 lines) Patch
M isolate.py View 3 chunks +16 lines, -7 lines 2 comments Download
M tests/isolate_test.py View 3 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 5
M-A
11 years, 4 months ago (2014-03-18 16:42:02 UTC) #1
vadimsh
lgtm https://codereview.appspot.com/77480043/diff/1/isolate.py File isolate.py (right): https://codereview.appspot.com/77480043/diff/1/isolate.py#newcode869 isolate.py:869: complete_state = CompleteState(None, SavedState(os.getcwd())) maybe temp dir instead ...
11 years, 4 months ago (2014-03-18 18:12:16 UTC) #2
M-A
https://codereview.appspot.com/77480043/diff/1/isolate.py File isolate.py (right): https://codereview.appspot.com/77480043/diff/1/isolate.py#newcode869 isolate.py:869: complete_state = CompleteState(None, SavedState(os.getcwd())) On 2014/03/18 18:12:16, vadimsh wrote: ...
11 years, 4 months ago (2014-03-18 18:31:32 UTC) #3
vadimsh
On 2014/03/18 18:31:32, M-A wrote: > https://codereview.appspot.com/77480043/diff/1/isolate.py > File isolate.py (right): > > https://codereview.appspot.com/77480043/diff/1/isolate.py#newcode869 > ...
11 years, 4 months ago (2014-03-18 18:32:14 UTC) #4
M-A
11 years, 4 months ago (2014-03-18 18:33:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r8472efa (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b