Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(877)

Issue 7693044: code review 7693044: encoding/base32: don't panic when decoding "AAAA==". (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by nigeltao
Modified:
11 years ago
Reviewers:
CC:
dsymonds, golang-dev
Visibility:
Public.

Description

encoding/base32: don't panic when decoding "AAAA==". Edit encoding/base64's internals and tests to match encoding/base32. Properly handling line breaks in padding is left for another CL.

Patch Set 1 #

Patch Set 2 : diff -r 969045163653 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 969045163653 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 25b2d31c3148 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -39 lines) Patch
M src/pkg/encoding/base32/base32.go View 1 2 3 4 chunks +22 lines, -12 lines 0 comments Download
M src/pkg/encoding/base32/base32_test.go View 1 2 3 1 chunk +32 lines, -11 lines 0 comments Download
M src/pkg/encoding/base64/base64.go View 1 2 chunks +3 lines, -5 lines 0 comments Download
M src/pkg/encoding/base64/base64_test.go View 1 2 3 2 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 4
nigeltao
Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years ago (2013-03-11 04:58:59 UTC) #1
dsymonds
LGTM but sit on it for a day so other eyes can check it. https://codereview.appspot.com/7693044/diff/5001/src/pkg/encoding/base32/base32_test.go ...
11 years ago (2013-03-11 05:07:53 UTC) #2
nigeltao
On Mon, Mar 11, 2013 at 3:59 PM, <nigeltao@golang.org> wrote: > encoding/base32: don't panic when ...
11 years ago (2013-03-11 05:14:47 UTC) #3
nigeltao
11 years ago (2013-03-12 00:07:44 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=01ef5b01146c ***

encoding/base32: don't panic when decoding "AAAA==".

Edit encoding/base64's internals and tests to match encoding/base32.

Properly handling line breaks in padding is left for another CL.

R=dsymonds
CC=golang-dev
https://codereview.appspot.com/7693044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b