Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(155)

Issue 7691046: Mac16 and Mac64 support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by Tommaso Pecorella
Modified:
10 years, 8 months ago
Reviewers:
Tom Henderson
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This changeset does the following: 1) it aligns the already existing Mac64Address to the Mac48Address structure 2) it adds the new Mac16Address 3) it introduces support for both of Mac16Address and Mac64Address into the IPv6 stack, making it possible to allocate an IPv6 address from either using self-configured addresses.

Patch Set 1 : Compile before refreshing patches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+594 lines, -21 lines) Patch
M src/internet/helper/ipv6-address-helper.cc View 2 chunks +19 lines, -3 lines 0 comments Download
M src/internet/model/ipv6-interface.cc View 2 chunks +13 lines, -1 line 0 comments Download
M src/internet/model/ipv6-l3-protocol.cc View 2 chunks +11 lines, -1 line 0 comments Download
M src/network/utils/address-utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/network/utils/address-utils.cc View 4 chunks +30 lines, -0 lines 0 comments Download
M src/network/utils/ipv6-address.h View 4 chunks +32 lines, -0 lines 0 comments Download
M src/network/utils/ipv6-address.cc View 4 chunks +74 lines, -0 lines 0 comments Download
A src/network/utils/mac16-address.h View 1 chunk +127 lines, -0 lines 0 comments Download
A src/network/utils/mac16-address.cc View 1 chunk +210 lines, -0 lines 0 comments Download
M src/network/utils/mac64-address.h View 2 chunks +30 lines, -2 lines 0 comments Download
M src/network/utils/mac64-address.cc View 4 chunks +40 lines, -14 lines 0 comments Download
M src/network/wscript View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Tommaso Pecorella
Didn't update the code review, however there's a typo to be fixed. The Mac64 is ...
10 years, 11 months ago (2013-04-08 15:03:11 UTC) #1
Tommaso Pecorella
10 years, 10 months ago (2013-05-15 17:57:37 UTC) #2
Tommaso Pecorella
10 years, 10 months ago (2013-05-15 18:06:18 UTC) #3
Tom Henderson
10 years, 8 months ago (2013-07-12 18:55:28 UTC) #4
I reviewed and found no issues.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b