Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(830)

Issue 7651045: code review 7651045: net/http: deflake test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by dvyukov
Modified:
11 years ago
Reviewers:
CC:
golang-dev, albert.strasheim, bradfitz
Visibility:
Public.

Description

net/http: deflake test Update issue 5005.

Patch Set 1 #

Patch Set 2 : diff -r 1da9617aaae9 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 1da9617aaae9 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 1da9617aaae9 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 1

Patch Set 5 : diff -r 1da9617aaae9 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 15d86e64b42e https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/net/http/fs_test.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years ago (2013-03-11 18:48:47 UTC) #1
albert.strasheim
On 2013/03/11 18:48:47, dvyukov wrote: > Hello mailto:golang-dev@googlegroups.com, > I'd like you to review this ...
11 years ago (2013-03-11 19:26:06 UTC) #2
bradfitz
LGTM https://codereview.appspot.com/7651045/diff/6001/src/pkg/net/http/fs_test.go File src/pkg/net/http/fs_test.go (right): https://codereview.appspot.com/7651045/diff/6001/src/pkg/net/http/fs_test.go#newcode699 src/pkg/net/http/fs_test.go:699: child := exec.Command("strace", "-f", os.Args[0], "-test.run=TestLinuxSendfileChild") could you ...
11 years ago (2013-03-11 19:29:59 UTC) #3
bradfitz
On Mon, Mar 11, 2013 at 12:26 PM, <fullung@gmail.com> wrote: > On 2013/03/11 18:48:47, dvyukov ...
11 years ago (2013-03-11 19:30:15 UTC) #4
albert.strasheim
On 2013/03/11 19:29:59, bradfitz wrote: > LGTM > https://codereview.appspot.com/7651045/diff/6001/src/pkg/net/http/fs_test.go > File src/pkg/net/http/fs_test.go (right): > https://codereview.appspot.com/7651045/diff/6001/src/pkg/net/http/fs_test.go#newcode699 ...
11 years ago (2013-03-11 19:34:26 UTC) #5
dvyukov
PTAL The secret source is: -q Suppress messages about attaching, detaching etc. This happens automatically ...
11 years ago (2013-03-12 08:09:29 UTC) #6
albert.strasheim
LGTM sauce
11 years ago (2013-03-12 08:35:22 UTC) #7
dvyukov
On Tue, Mar 12, 2013 at 12:35 PM, <fullung@gmail.com> wrote: > LGTM > > sauce ...
11 years ago (2013-03-12 08:52:58 UTC) #8
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=e641fed2fe46 *** net/http: deflake test Update issue 5005. R=golang-dev, fullung, bradfitz CC=golang-dev ...
11 years ago (2013-03-12 08:53:05 UTC) #9
bradfitz
11 years ago (2013-03-12 11:14:14 UTC) #10
Thanks!

On Tue, Mar 12, 2013 at 1:09 AM, <dvyukov@google.com> wrote:

> PTAL
>
> The secret source is:
>        -q          Suppress messages about attaching, detaching etc.
> This happens automatically when output is redirected to a file and the
> command is  run  directly  instead  of
>                    attaching.
>
> and "-e", "trace=sendfile,sendfile64" makes the output way shorter. I
> think that full output is not actionable anyway.
>
>
https://codereview.appspot.**com/7651045/<https://codereview.appspot.com/7651...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b