On 2013/03/11 18:48:47, dvyukov wrote: > Hello mailto:golang-dev@googlegroups.com, > I'd like you to review this ...
11 years, 1 month ago
(2013-03-11 19:26:06 UTC)
#2
On 2013/03/11 18:48:47, dvyukov wrote:
> Hello mailto:golang-dev@googlegroups.com,
> I'd like you to review this change to
> https://dvyukov%2540google.com%40code.google.com/p/go/
Could a better way to write this test be to use Ptrace*?
11 years, 1 month ago
(2013-03-11 19:34:26 UTC)
#5
On 2013/03/11 19:29:59, bradfitz wrote:
> LGTM
> https://codereview.appspot.com/7651045/diff/6001/src/pkg/net/http/fs_test.go
> File src/pkg/net/http/fs_test.go (right):
>
https://codereview.appspot.com/7651045/diff/6001/src/pkg/net/http/fs_test.go#...
> src/pkg/net/http/fs_test.go:699: child := exec.Command("strace", "-f",
> os.Args[0], "-test.run=TestLinuxSendfileChild")
> could you add to this:
> "strace", "-f", "-e", "trace=sendfile,sendfile64", os.Args[0],
> "-test.run=TestLinuxSendfileChild")
> That should reduce any false positives from just looking for "sendfile" in the
> output.
If the test doesn't print anything on stdout you could consider using
-o/dev/stdout to separate the trace stuff from other output like "Attached PID
whatever"?
Regards
Albert
PTAL The secret source is: -q Suppress messages about attaching, detaching etc. This happens automatically ...
11 years, 1 month ago
(2013-03-12 08:09:29 UTC)
#6
PTAL
The secret source is:
-q Suppress messages about attaching, detaching etc. This
happens automatically when output is redirected to a file and the command is
run directly instead of
attaching.
and "-e", "trace=sendfile,sendfile64" makes the output way shorter. I think that
full output is not actionable anyway.
Thanks! On Tue, Mar 12, 2013 at 1:09 AM, <dvyukov@google.com> wrote: > PTAL > > ...
11 years, 1 month ago
(2013-03-12 11:14:14 UTC)
#10
Thanks!
On Tue, Mar 12, 2013 at 1:09 AM, <dvyukov@google.com> wrote:
> PTAL
>
> The secret source is:
> -q Suppress messages about attaching, detaching etc.
> This happens automatically when output is redirected to a file and the
> command is run directly instead of
> attaching.
>
> and "-e", "trace=sendfile,sendfile64" makes the output way shorter. I
> think that full output is not actionable anyway.
>
>
https://codereview.appspot.**com/7651045/<https://codereview.appspot.com/7651...
>
Issue 7651045: code review 7651045: net/http: deflake test
(Closed)
Created 11 years, 1 month ago by dvyukov
Modified 11 years, 1 month ago
Reviewers:
Base URL:
Comments: 1