Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(545)

Issue 76450043: code review 76450043: cmd/cgo: enforce typing of 0-sized types (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by DMorsing
Modified:
5 years, 7 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews, bradfitz, iant
Visibility:
Public.

Description

cmd/cgo: enforce typing of 0-sized types cgo represents all 0-sized and unsized types internally as [0]byte. This means that pointers to incomplete types would be interchangable, even if given a name by typedef. Fixes issue 7409.

Patch Set 1 #

Patch Set 2 : diff -r 1849f83423ca https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1849f83423ca https://code.google.com/p/go/ #

Patch Set 4 : diff -r 3c890c5bf4e3 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
A misc/cgo/errors/err3.go View 1 1 chunk +18 lines, -0 lines 0 comments Download
M misc/cgo/errors/test.bash View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/cgo/gcc.go View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6
DMorsing
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
5 years, 8 months ago (2014-03-15 21:55:26 UTC) #1
bradfitz
R=iant On Sat, Mar 15, 2014 at 2:55 PM, <daniel.morsing@gmail.com> wrote: > Reviewers: golang-codereviews, > ...
5 years, 8 months ago (2014-03-17 21:40:40 UTC) #2
DMorsing
Ping?
5 years, 7 months ago (2014-03-26 15:03:35 UTC) #3
iant
LGTM
5 years, 7 months ago (2014-03-26 15:38:07 UTC) #4
DMorsing
*** Submitted as https://code.google.com/p/go/source/detail?r=a70a32dc121a *** cmd/cgo: enforce typing of 0-sized types cgo represents all 0-sized ...
5 years, 7 months ago (2014-03-27 20:23:20 UTC) #5
gobot
5 years, 7 months ago (2014-03-27 20:27:59 UTC) #6
Message was sent while issue was closed.
This CL appears to have broken the windows-amd64-race builder.
See http://build.golang.org/log/d3a03c248ad7b7ddb7d38227f6b0d0d6d3764ece
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b