code review 7628047: go.exp/locale: Added table generator and lookup code fo...

go.exp/locale: Added table generator and lookup code for low-level tables.

[mpvl, 2013-03-15 11:47:20]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.exp/

[r, 2013-03-21 20:59:48]

LGTM

https://codereview.appspot.com/7628047/diff/2001/locale/lookup.go
File locale/lookup.go (right):

https://codereview.appspot.com/7628047/diff/2001/locale/lookup.go#newcode20
locale/lookup.go:20: }) << 2
wow

https://codereview.appspot.com/7628047/diff/2001/locale/maketables.go
File locale/maketables.go (right):

https://codereview.appspot.com/7628047/diff/2001/locale/maketables.go#newcode126
locale/maketables.go:126: if ss.typ != 0 {
this is fine but i'd use &&

[mpvl, 2013-03-25 19:12:39]

*** Submitted as
https://code.google.com/p/go/source/detail?r=cf222d8ab73e&repo=exp ***

go.exp/locale: Added table generator and lookup code for low-level tables.

R=r
CC=golang-dev
https://codereview.appspot.com/7628047

[albert.strasheim, 2013-03-29 17:37:36]

On 2013/03/25 19:12:39, mpvl wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=cf222d8ab73e&repo=exp ***
> go.exp/locale: Added table generator and lookup code for low-level tables.

It would be nice if we could fix these tests to work with multiple cpu values.
We're close to having all the subrepos pass the stress tests.

$ go test -cpu 1,1 -short code.google.com/p/go.exp/locale
--- FAIL: TestSearch (0.00 seconds)
	lookup_test.go:41: aaax: found 16; want -1
	lookup_test.go:41: bbbb: found 28; want -1
	lookup_test.go:41:     : found 0; want -1
FAIL
FAIL	code.google.com/p/go.exp/locale	0.005s

[mpvl_google.com, 2013-03-30 22:41:11]

sent out CL to fix this.


On Fri, Mar 29, 2013 at 6:37 PM, <fullung@gmail.com> wrote:

> On 2013/03/25 19:12:39, mpvl wrote:
>
>> *** Submitted as
>>
https://code.google.com/p/go/**source/detail?r=cf222d8ab73e&**repo=exp<https:...
>> go.exp/locale: Added table generator and lookup code for low-level
>>
> tables.
>
> It would be nice if we could fix these tests to work with multiple cpu
> values. We're close to having all the subrepos pass the stress tests.
>
> $ go test -cpu 1,1 -short
code.google.com/p/go.exp/**locale<http://code.google.com/p/go.exp/locale>
> --- FAIL: TestSearch (0.00 seconds)
>         lookup_test.go:41: aaax: found 16; want -1
>         lookup_test.go:41: bbbb: found 28; want -1
>         lookup_test.go:41:     : found 0; want -1
> FAIL
> FAIL   
code.google.com/p/go.exp/**locale<http://code.google.com/p/go.exp/locale>0.005s
>
>
https://codereview.appspot.**com/7628047/<https://codereview.appspot.com/7628...
>



-- 
Trying this for a while: http://go/OnlyCheckEmailTwiceADay.
Marcel van Lohuizen -- Google Switzerland GmbH -- Identifikationsnummer:
CH-020.4.028.116-1