Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1726)

Issue 7628043: code review 7628043: misc/emacs: Fix indentation for code following multilin... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by Dominik Honnef
Modified:
11 years, 1 month ago
Reviewers:
CC:
adonovan, cw, pah, golang-dev
Visibility:
Public.

Description

misc/emacs: Fix indentation for code following multiline function declarations Correctly indent the body of functions that have been declared over multiple lines. See http://play.golang.org/p/MHMwNDbFyf for an example. Previously, the body of the function would be indented as deep as the continuation line of the function declaration. Now it gets indented as deep as the func keyword.

Patch Set 1 #

Patch Set 2 : diff -r ed48ace1855b https://code.google.com/p/go #

Patch Set 3 : diff -r ed48ace1855b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
M misc/emacs/go-mode.el View 1 4 chunks +38 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Dominik Honnef
Hello adonovan@google.com, cw@f00f.org, patrick.allen.higgins@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 1 month ago (2013-03-08 05:24:18 UTC) #1
cw
Working here, LGTM.
11 years, 1 month ago (2013-03-08 05:33:05 UTC) #2
Dominik Honnef
*bump*
11 years, 1 month ago (2013-03-13 03:52:34 UTC) #3
cw
Sorry, I thought I replied already. I'm using this here without problems. LGTM.
11 years, 1 month ago (2013-03-13 04:01:09 UTC) #4
Dominik Honnef
On 2013/03/13 04:01:09, cw wrote: > Sorry, I thought I replied already. > > I'm ...
11 years, 1 month ago (2013-03-13 04:12:03 UTC) #5
bradfitz
11 years, 1 month ago (2013-03-13 04:37:17 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=dfbaf2b999a6 ***

misc/emacs: Fix indentation for code following multiline function declarations

Correctly indent the body of functions that have been declared
over multiple lines. See http://play.golang.org/p/MHMwNDbFyf for
an example.

Previously, the body of the function would be indented as deep as
the continuation line of the function declaration. Now it gets
indented as deep as the func keyword.

R=adonovan, cw, patrick.allen.higgins
CC=golang-dev
https://codereview.appspot.com/7628043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b