code review 76150044: reflect: correct alignment of call arguments on amd64p32.

reflect: correct alignment of call arguments on amd64p32.

Changes adapted from original CL 15680044.

[remyoudompheng, 2014-03-15 17:15:12]

Hello rsc@golang.org, iant@golang.org, dave@cheney.net (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[iant, 2014-03-18 18:05:34]

https://codereview.appspot.com/76150044/diff/40001/src/pkg/reflect/value.go
File src/pkg/reflect/value.go (right):

https://codereview.appspot.com/76150044/diff/40001/src/pkg/reflect/value.go#n...
src/pkg/reflect/value.go:630: if runtime.GOARCH == "amd64p32" {
I think this would be clearer if we do the same thing we do in funcLayout:
        off = align(off, ptrSize)
        if runtime.GOARCH = "amd64p32" {
                off = align(off, 8)
        }

https://codereview.appspot.com/76150044/diff/40001/src/pkg/reflect/value.go#n...
src/pkg/reflect/value.go:758: // and return values depends on whether there is a
receiver or
I don't entirely understand this comment.  We can only get here via
makeMethodValue.  There is always a receiver--in fact, it's the value in rcvr.

[remyoudompheng, 2014-03-20 06:19:25]

Hello rsc@golang.org, iant@golang.org, dave@cheney.net (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[remyoudompheng, 2014-03-20 06:20:16]

https://codereview.appspot.com/76150044/diff/40001/src/pkg/reflect/value.go
File src/pkg/reflect/value.go (right):

https://codereview.appspot.com/76150044/diff/40001/src/pkg/reflect/value.go#n...
src/pkg/reflect/value.go:630: if runtime.GOARCH == "amd64p32" {
On 2014/03/18 18:05:34, iant wrote:
> I think this would be clearer if we do the same thing we do in funcLayout:
>         off = align(off, ptrSize)
>         if runtime.GOARCH = "amd64p32" {
>                 off = align(off, 8)
>         }

Done.

[iant, 2014-03-20 17:13:40]

LGTM

[remyoudompheng, 2014-03-20 21:22:16]

*** Submitted as https://code.google.com/p/go/source/detail?r=ab0ea248ed7c ***

reflect: correct alignment of call arguments on amd64p32.

Changes adapted from original CL 15680044.

LGTM=iant
R=rsc, iant, dave
CC=golang-codereviews
https://codereview.appspot.com/76150044

[gobot, 2014-03-20 23:12:08]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/c1803810a4246d9ed8b9673ae4481b9b548b35a7