Issue 76050044: code review 76050044: liblink, runtime: make nacl/386 binaries valid.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 76050044: code review 76050044: liblink, runtime: make nacl/386 binaries valid. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by remyoudompheng

Modified:
10 years, 1 month ago

Reviewers:
iant

CC:
rsc, dave_cheney.net, iant, golang-codereviews

Visibility:
Public.

Description

liblink, runtime: make nacl/386 binaries valid. They were rejected by NaCl due to AES instructions and accesses to %gs:0x8, caused by wrong tlsoffset value.

Patch Set 1 #

Patch Set 2 : diff -r ea25f3ec3561 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ea25f3ec3561 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7feb25aa5a8e https://go.googlecode.com/hg/ #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	src/liblink/sym.c	View	1	1 chunk	+11 lines, -2 lines	0 comments	Download
	M	src/pkg/runtime/alg.goc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

remyoudompheng

Hello rsc@golang.org, dave@cheney.net, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 1 month ago (2014-03-14 19:33:45 UTC) #1

remyoudompheng

10 years, 1 month ago (2014-03-14 20:38:06 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=9eb0e586ec54 ***

liblink, runtime: make nacl/386 binaries valid.

They were rejected by NaCl due to AES instructions and
accesses to %gs:0x8, caused by wrong tlsoffset value.

LGTM=iant
R=rsc, dave, iant
CC=golang-codereviews
https://codereview.appspot.com/76050044

Expand All Messages | Collapse All Messages