Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3979)

Issue 7593050: code review 7593050: spec: fix description of initialization (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by r
Modified:
11 years, 1 month ago
Reviewers:
CC:
golang-dev, gri, rsc
Visibility:
Public.

Description

spec: fix description of initialization The analysis does not depend on the values of the items. Fixes issue 4648.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r a5c202b53a58 https://code.google.com/p/go #

Total comments: 1

Patch Set 3 : diff -r a5c202b53a58 https://code.google.com/p/go #

Patch Set 4 : diff -r df8aeafe67fd https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M doc/go_spec.html View 1 2 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 9
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 1 month ago (2013-03-20 20:53:54 UTC) #1
r
This brings the spec in line with both the intent and the existing implementations. The ...
11 years, 1 month ago (2013-03-20 20:54:36 UTC) #2
gri
+1 for removing the notion of value https://codereview.appspot.com/7593050/diff/1/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/7593050/diff/1/doc/go_spec.html#newcode5605 doc/go_spec.html:5605: topological reference ...
11 years, 1 month ago (2013-03-20 21:10:06 UTC) #3
r
Hello golang-dev@googlegroups.com, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 1 month ago (2013-03-20 21:24:54 UTC) #4
gri
LGTM https://codereview.appspot.com/7593050/diff/6001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/7593050/diff/6001/doc/go_spec.html#newcode5719 doc/go_spec.html:5719: order of reference: if the initializer of <code>A</code> ...
11 years, 1 month ago (2013-03-20 21:28:22 UTC) #5
r
Hello golang-dev@googlegroups.com, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 1 month ago (2013-03-20 21:51:13 UTC) #6
rsc
LGTM
11 years, 1 month ago (2013-03-20 22:01:47 UTC) #7
gri
LGTM
11 years, 1 month ago (2013-03-20 22:02:54 UTC) #8
r
11 years, 1 month ago (2013-03-20 22:05:30 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=85b1cc5d35dd ***

spec: fix description of initialization
The analysis does not depend on the values of the items.
Fixes issue 4648.

R=golang-dev, gri, rsc
CC=golang-dev
https://codereview.appspot.com/7593050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b