Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(180)

Issue 7593045: code review 7593045: runtime: Fix plan9 aes hash initialization. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by khr
Modified:
11 years ago
Reviewers:
akumar, rsc, khr1
CC:
golang-dev, r
Visibility:
Public.

Description

runtime: Fix plan9 aes hash initialization.

Patch Set 1 #

Patch Set 2 : diff -r e3a5e1e9db71 https://code.google.com/p/go/ #

Patch Set 3 : diff -r e3a5e1e9db71 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 1a329995118c https://code.google.com/p/go/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/pkg/runtime/env_plan9.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/os_plan9.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/pkg/runtime/thread_plan9.c View 1 4 chunks +10 lines, -3 lines 1 comment Download

Messages

Total messages: 7
khr
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years ago (2013-03-12 17:58:31 UTC) #1
r
LGTM
11 years ago (2013-03-12 18:00:38 UTC) #2
khr
*** Submitted as https://code.google.com/p/go/source/detail?r=69607fd643a9 *** runtime: Fix plan9 aes hash initialization. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/7593045
11 years ago (2013-03-12 18:03:19 UTC) #3
akumar
https://codereview.appspot.com/7593045/diff/10001/src/pkg/runtime/thread_plan9.c File src/pkg/runtime/thread_plan9.c (right): https://codereview.appspot.com/7593045/diff/10001/src/pkg/runtime/thread_plan9.c#newcode205 src/pkg/runtime/thread_plan9.c:205: fd = runtime·open((int8*)buf, OWRITE, 0); This gets a bit ...
11 years ago (2013-03-12 21:00:00 UTC) #4
khr1
That was just to avoid the (uint8*) cast on strings passed to runtime·open. (in thread_{linux,*bsd,darwin}.c) ...
11 years ago (2013-03-12 21:06:39 UTC) #5
rsc
Let's keep open the way it is now. Thanks.
11 years ago (2013-03-12 21:09:46 UTC) #6
akumar
11 years ago (2013-03-12 21:12:18 UTC) #7
Ah, alright, I missed that, sorry. Nevermind! :-)

On 12 March 2013 14:06, Keith Randall <khr@google.com> wrote:
> That was just to avoid the (uint8*) cast on strings passed to runtime·open.
> (in thread_{linux,*bsd,darwin}.c)
>
>
> On Tue, Mar 12, 2013 at 2:00 PM, <seed@mail.nanosouffle.net> wrote:
>>
>>
>>
>>
https://codereview.appspot.com/7593045/diff/10001/src/pkg/runtime/thread_plan9.c
>> File src/pkg/runtime/thread_plan9.c (right):
>>
>>
>>
https://codereview.appspot.com/7593045/diff/10001/src/pkg/runtime/thread_plan...
>> src/pkg/runtime/thread_plan9.c:205: fd = runtime·open((int8*)buf,
>> OWRITE, 0);
>> This gets a bit cumbersome - I can change my uint8*s to int8*s, but is
>> there a reason that open was defined this way in your previous CL,
>> 7543043? If there's no disagreement, it'd be nice to keep the type of
>> the first argument the same (I can send in the CL if you like).
>>
>> https://codereview.appspot.com/7593045/
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b