code review 7592043: crypto: implemented hash based key derivation (HKDF).

crypto: implemented hash based key derivation (HKDF).

Detailed description in RFC 5869.

[karalabe, 2013-03-07 20:12:50]

Hello agl@chromium.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[ality, 2013-03-07 20:34:06]

This should probably be in the go.crypto subrepository.

  Anthony

[minux1, 2013-03-07 20:34:48]

please move this to go.crypto sub-repository.
(go get code.google.com/p/go.crypto, and move hkdf to
$GOPATH/src/code.google.com/p/go.crypto and mail
a new CL)

also note: as it's close to Go 1.1 release, we're now in
Go 1.1 freezing period, please wait until after Go 1.1
is released. for details, see http://golang.org/s/go11freeze

Thank you!

https://codereview.appspot.com/7592043/diff/5001/src/pkg/crypto/hkdf/hkdf.go
File src/pkg/crypto/hkdf/hkdf.go (right):

https://codereview.appspot.com/7592043/diff/5001/src/pkg/crypto/hkdf/hkdf.go#...
src/pkg/crypto/hkdf/hkdf.go:5: // Package hkdf implements the HMAC-based
Extract-and-Expand Key Derivation
blank lines below make this not a package document.
please put // on blank lines below.

https://codereview.appspot.com/7592043/diff/5001/src/pkg/crypto/hkdf/hkdf.go#...
src/pkg/crypto/hkdf/hkdf.go:15: 
and delete this blank line.

https://codereview.appspot.com/7592043/diff/5001/src/pkg/crypto/hkdf/hkdf.go#...
src/pkg/crypto/hkdf/hkdf.go:63: // New returns a new HKDF using the given
hash.Hash type, the mater keying material
s/mater/master/
s/given hash.Hash type/given hash.Hash constructor/

[karalabe, 2013-03-07 22:19:56]

Sorry about the wrong (sub)repo. Wasn't aware that they are separated (even
though there was a reference by agl to it). I'll update and open a new
change-list.

Btw, when is Go 1.1 planned to be released? I.e. when should I submit the new
review request?

Thanks!

[karalabe, 2013-03-15 10:51:07]

I guess this code review request can be closed down since there's a new one with
the correct sub-project: https://codereview.appspot.com/7474049/ .

[r, 2013-03-15 14:40:51]

You can do it: hg change -d 7592043

[karalabe, 2013-03-16 12:55:53]

*** Abandoned ***