Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1149)

Issue 75600044: Preliminary support for basic juju id commands:

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by mattyw
Modified:
9 years, 12 months ago
Reviewers:
mp+210962, fwereade, rog
Visibility:
Public.

Description

Preliminary support for basic juju id commands: juju add-user <username> <password> if password is not supplied uses gopass to take the password from the command line juju remove-user <username> doesn't actually remove the user. But mark them as inactive add-user and remove-user aren't registered yet as they are useless without login. But the details of this are still being worked out. This branch also contains fixes for lp:1285256. The EnvCommandBase struct includes a function for ensuring the envname is not "". This replaces a review at https://codereview.appspot.com/51450047/ https://code.launchpad.net/~mattyw/juju-core/user-add-remove-cli/+merge/210962 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Preliminary support for basic juju id commands: #

Total comments: 25

Patch Set 3 : Preliminary support for basic juju id commands: #

Total comments: 13

Patch Set 4 : Preliminary support for basic juju id commands: #

Total comments: 7

Patch Set 5 : Preliminary support for basic juju id commands: #

Total comments: 8

Patch Set 6 : Preliminary support for basic juju id commands: #

Patch Set 7 : Preliminary support for basic juju id commands: #

Total comments: 19

Patch Set 8 : Preliminary support for basic juju id commands: #

Total comments: 6

Patch Set 9 : Preliminary support for basic juju id commands: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+648 lines, -128 lines) Patch
A [revision details] View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/cmd.go View 1 2 3 4 5 6 7 3 chunks +7 lines, -7 lines 0 comments Download
M cmd/envcmd/environmentcommand.go View 1 2 3 4 5 6 7 4 chunks +15 lines, -2 lines 0 comments Download
M cmd/envcmd/environmentcommand_test.go View 2 chunks +21 lines, -18 lines 0 comments Download
M cmd/envcmd/export_test.go View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/addmachine.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/addrelation.go View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/addunit.go View 2 chunks +2 lines, -1 line 0 comments Download
A cmd/juju/adduser.go View 1 2 3 4 5 6 7 8 1 chunk +103 lines, -0 lines 0 comments Download
A cmd/juju/adduser_test.go View 1 2 3 4 5 1 chunk +106 lines, -0 lines 0 comments Download
M cmd/juju/authorisedkeys_add.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/authorisedkeys_delete.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/authorisedkeys_import.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/authorisedkeys_list.go View 1 2 3 4 5 6 7 3 chunks +10 lines, -1 line 0 comments Download
M cmd/juju/bootstrap.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/bootstrap_test.go View 1 2 3 4 5 6 7 3 chunks +2 lines, -5 lines 0 comments Download
M cmd/juju/cmd_test.go View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M cmd/juju/constraints.go View 1 2 3 4 5 6 7 5 chunks +11 lines, -2 lines 0 comments Download
M cmd/juju/debuglog_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M cmd/juju/deploy.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/destroymachine.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/destroyrelation.go View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/destroyservice.go View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/destroyunit.go View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/endpoint.go View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/ensureavailability.go View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/environment.go View 1 2 3 4 5 6 7 8 7 chunks +16 lines, -3 lines 0 comments Download
M cmd/juju/expose.go View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/get.go View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/plugin.go View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments Download
M cmd/juju/publish.go View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/publish_test.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -5 lines 0 comments Download
A cmd/juju/removeuser.go View 1 2 3 4 5 6 7 1 chunk +55 lines, -0 lines 0 comments Download
A cmd/juju/removeuser_test.go View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M cmd/juju/resolved.go View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/retryprovisioning.go View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M cmd/juju/run.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/run_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/set.go View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/ssh.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/status.go View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments Download
M cmd/juju/switch.go View 3 chunks +3 lines, -2 lines 0 comments Download
M cmd/juju/switch_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M cmd/juju/synctools.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/unexpose.go View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/unset.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/upgradecharm.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/juju/upgradejuju.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/jujud/run_test.go View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M cmd/plugins/juju-metadata/imagemetadata.go View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M cmd/plugins/juju-metadata/toolsmetadata.go View 1 2 3 4 5 6 7 3 chunks +10 lines, -1 line 0 comments Download
M cmd/plugins/juju-metadata/validateimagemetadata.go View 1 2 3 4 5 6 7 4 chunks +7 lines, -2 lines 0 comments Download
M cmd/plugins/juju-metadata/validatetoolsmetadata.go View 1 2 3 4 5 6 7 4 chunks +7 lines, -2 lines 0 comments Download
M cmd/plugins/juju-restore/restore.go View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M cmd/supercommand.go View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M environs/configstore/disk.go View 1 2 3 4 5 6 7 6 chunks +23 lines, -18 lines 0 comments Download
M environs/configstore/mem.go View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M environs/manual/init_test.go View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M environs/manual/provisioner_test.go View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M juju/api.go View 1 2 3 4 5 6 2 chunks +9 lines, -0 lines 0 comments Download
M state/api/params/params.go View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download
M state/apiserver/client/api_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/user_test.go View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M testing/environ.go View 1 2 3 4 5 6 7 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 20
mattyw
Please take a look.
10 years ago (2014-03-14 05:17:51 UTC) #1
mattyw
On 2014/03/14 05:17:51, mattyw wrote: > Please take a look. This follows on from the ...
10 years ago (2014-03-14 11:34:35 UTC) #2
fwereade
Sorry, I don't think we're quite done here yet. I am very happy with the ...
10 years ago (2014-03-18 01:11:39 UTC) #3
mattyw
Updated the comments, stuff I haven't commented on is stuff I will do https://codereview.appspot.com/75600044/diff/20001/cmd/juju/adduser.go File ...
10 years ago (2014-03-18 03:45:21 UTC) #4
mattyw
https://codereview.appspot.com/75600044/diff/20001/errors/errors.go File errors/errors.go (right): https://codereview.appspot.com/75600044/diff/20001/errors/errors.go#newcode98 errors/errors.go:98: return fmt.Sprintf("rc: %v", e.Code) On 2014/03/18 01:11:39, fwereade wrote: ...
10 years ago (2014-03-26 15:01:28 UTC) #5
mattyw
Please take a look. https://codereview.appspot.com/75600044/diff/20001/cmd/juju/adduser_test.go File cmd/juju/adduser_test.go (right): https://codereview.appspot.com/75600044/diff/20001/cmd/juju/adduser_test.go#newcode21 cmd/juju/adduser_test.go:21: func (s *AddUserSuite) Testadduser(c *gc.C) ...
10 years ago (2014-03-27 10:20:17 UTC) #6
fwereade
TYVM for all the fixes -- a couple of bits need some work, but they'll ...
10 years ago (2014-03-27 12:14:34 UTC) #7
mattyw
Please take a look. https://codereview.appspot.com/75600044/diff/40001/cmd/juju/adduser.go File cmd/juju/adduser.go (right): https://codereview.appspot.com/75600044/diff/40001/cmd/juju/adduser.go#newcode61 cmd/juju/adduser.go:61: pass, err := terminal.ReadPassword(0) On ...
10 years ago (2014-03-27 17:12:08 UTC) #8
fwereade
Couple more tweaks to the command, and a couple of tests (and the json marshalling); ...
10 years ago (2014-03-27 17:27:23 UTC) #9
mattyw
Please take a look. https://codereview.appspot.com/75600044/diff/60001/cmd/juju/adduser.go File cmd/juju/adduser.go (right): https://codereview.appspot.com/75600044/diff/60001/cmd/juju/adduser.go#newcode21 cmd/juju/adduser.go:21: when the environent is destroyed. ...
10 years ago (2014-03-28 07:25:32 UTC) #10
fwereade
LGTM with trivial fixes: https://codereview.appspot.com/75600044/diff/80001/cmd/juju/adduser.go File cmd/juju/adduser.go (right): https://codereview.appspot.com/75600044/diff/80001/cmd/juju/adduser.go#newcode22 cmd/juju/adduser.go:22: An example jenv file will ...
10 years ago (2014-03-28 10:09:21 UTC) #11
mattyw
Please take a look. https://codereview.appspot.com/75600044/diff/80001/cmd/juju/adduser.go File cmd/juju/adduser.go (right): https://codereview.appspot.com/75600044/diff/80001/cmd/juju/adduser.go#newcode22 cmd/juju/adduser.go:22: An example jenv file will ...
10 years ago (2014-03-28 11:00:28 UTC) #12
fwereade
LGTM, thanks
10 years ago (2014-03-28 11:26:50 UTC) #13
mattyw
Please take a look.
10 years ago (2014-03-28 12:34:37 UTC) #14
rog
Looks great in general, with some comments and suggestions below. https://codereview.appspot.com/75600044/diff/120001/cmd/envcmd/environmentcommand.go File cmd/envcmd/environmentcommand.go (right): https://codereview.appspot.com/75600044/diff/120001/cmd/envcmd/environmentcommand.go#newcode67 ...
9 years, 12 months ago (2014-03-31 14:21:12 UTC) #15
mattyw
https://codereview.appspot.com/75600044/diff/120001/cmd/envcmd/environmentcommand.go File cmd/envcmd/environmentcommand.go (right): https://codereview.appspot.com/75600044/diff/120001/cmd/envcmd/environmentcommand.go#newcode67 cmd/envcmd/environmentcommand.go:67: func (c *EnvCommandBase) EnsureEnvNameSet() error { On 2014/03/31 14:21:12, ...
9 years, 12 months ago (2014-04-01 08:07:30 UTC) #16
mattyw
Please take a look.
9 years, 12 months ago (2014-04-01 08:27:35 UTC) #17
fwereade
I'm a little bit irritated at the changes to EnsureEnvNameSet, and the EnvironInfoData type, but ...
9 years, 12 months ago (2014-04-01 09:40:52 UTC) #18
mattyw
https://codereview.appspot.com/75600044/diff/140001/cmd/juju/adduser.go File cmd/juju/adduser.go (right): https://codereview.appspot.com/75600044/diff/140001/cmd/juju/adduser.go#newcode98 cmd/juju/adduser.go:98: c.out.Write(ctx, outputInfo) On 2014/04/01 09:40:54, fwereade wrote: > doesn't ...
9 years, 12 months ago (2014-04-01 14:31:01 UTC) #19
mattyw
9 years, 12 months ago (2014-04-01 14:37:05 UTC) #20
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b