Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(690)

Issue 7488043: Add Delta and MarshalJSON for megawatcher

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by gary.poster
Modified:
6 years, 10 months ago
Reviewers:
dimitern, mp+151821, rog
Visibility:
Public.

Description

Add Delta and MarshalJSON for megawatcher This code is largely from Roger, with tests from Benji and me. This simply adds a Delta object that can marshal in the same way as PyJuju. It includes stubs for the four types of entity information we should need. https://code.launchpad.net/~gary/juju-core/megawatcher_delta/+merge/151821 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 7

Patch Set 2 : Add Delta and MarshalJSON for megawatcher #

Patch Set 3 : Add Delta and MarshalJSON for megawatcher #

Patch Set 4 : Add Delta and MarshalJSON for megawatcher #

Patch Set 5 : Add Delta and MarshalJSON for megawatcher #

Patch Set 6 : Add Delta and MarshalJSON for megawatcher #

Patch Set 7 : Add Delta and MarshalJSON for megawatcher #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -0 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A state/megawatcher.go View 1 1 chunk +83 lines, -0 lines 0 comments Download
A state/megawatcher_test.go View 1 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 5
gary.poster
Please take a look.
6 years, 10 months ago (2013-03-05 19:00:40 UTC) #1
dimitern
LGTM, just a couple of trivials. https://codereview.appspot.com/7488043/diff/1/state/megawatcher.go File state/megawatcher.go (right): https://codereview.appspot.com/7488043/diff/1/state/megawatcher.go#newcode13 state/megawatcher.go:13: Remove bool s/Remove/Removed/ ...
6 years, 10 months ago (2013-03-05 19:06:57 UTC) #2
rog
LGTM https://codereview.appspot.com/7488043/diff/1/state/megawatcher.go File state/megawatcher.go (right): https://codereview.appspot.com/7488043/diff/1/state/megawatcher.go#newcode13 state/megawatcher.go:13: Remove bool On 2013/03/05 19:06:57, dimitern wrote: > ...
6 years, 10 months ago (2013-03-05 20:26:29 UTC) #3
gary.poster
Thank you! Gary https://codereview.appspot.com/7488043/diff/1/state/megawatcher.go File state/megawatcher.go (right): https://codereview.appspot.com/7488043/diff/1/state/megawatcher.go#newcode13 state/megawatcher.go:13: Remove bool On 2013/03/05 19:06:57, dimitern ...
6 years, 10 months ago (2013-03-06 03:29:28 UTC) #4
gary.poster
6 years, 10 months ago (2013-03-06 13:20:28 UTC) #5
*** Submitted:

Add Delta and MarshalJSON for megawatcher

This code is largely from Roger, with tests from Benji and me.  This simply
adds a Delta object that can marshal in the same way as PyJuju.  It includes
stubs for the four types of entity information we should need.

R=dimitern, rog
CC=
https://codereview.appspot.com/7488043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b