Issue 7457045: code review 7457045: runtime, testing/quick: libffi doesn't handle complex o...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7457045: code review 7457045: runtime, testing/quick: libffi doesn't handle complex o... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by iant

Modified:
13 years, 3 months ago

Reviewers:

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

runtime, testing/quick: libffi doesn't handle complex on Alpha. From Uros Bizjak.

Patch Set 1 #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
	M	libgo/go/testing/quick/quick_test.go	View		2 chunks	+5 lines, -2 lines	0 comments	Download
	M	libgo/runtime/go-reflect-call.c	View		2 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

iant

Hello iant (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://gofrontend.googlecode.com/hg/

13 years, 3 months ago (2013-03-01 19:26:15 UTC) #1

iant

13 years, 3 months ago (2013-03-01 19:26:19 UTC) #2

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=8c0d464139d1 ***

runtime, testing/quick: libffi doesn't handle complex on Alpha.

From Uros Bizjak.

R=iant
CC=gofrontend-dev
https://codereview.appspot.com/7457045

Expand All Messages | Collapse All Messages