Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(995)

Issue 7450054: Add support for Go expose.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by bac
Modified:
10 years, 9 months ago
Reviewers:
benji, mp+151591, gary.poster
Visibility:
Public.

Description

Add support for Go expose. https://code.launchpad.net/~bac/juju-gui/go-expose/+merge/151591 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Patch Set 2 : Add support for Go expose. #

Patch Set 3 : Add support for Go expose. #

Patch Set 4 : Add support for Go expose. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -1 line) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/sandbox.js View 1 2 3 2 chunks +59 lines, -1 line 0 comments Download
M test/test_fakebackend.js View 1 2 3 1 chunk +117 lines, -0 lines 0 comments Download
M test/test_sandbox.js View 1 2 3 2 chunks +310 lines, -0 lines 0 comments Download

Messages

Total messages: 6
bac
Please take a look.
11 years ago (2013-03-04 19:17:41 UTC) #1
benji
LGTM with one trivial https://codereview.appspot.com/7450054/diff/1/test/test_env_go.js File test/test_env_go.js (right): https://codereview.appspot.com/7450054/diff/1/test/test_env_go.js#newcode166 test/test_env_go.js:166: assert.equal(err, 'service \"mysql\" not found'); ...
11 years ago (2013-03-04 21:13:55 UTC) #2
gary.poster
LGTM with trivial We talked about a way to test this with the actual Go ...
11 years ago (2013-03-04 21:17:07 UTC) #3
bac
*** Submitted: Add support for Go expose. R=gary.poster CC= https://codereview.appspot.com/7450054 https://codereview.appspot.com/7450054/diff/1/app/store/env/go.js File app/store/env/go.js (right): https://codereview.appspot.com/7450054/diff/1/app/store/env/go.js#newcode184 ...
11 years ago (2013-03-05 15:03:08 UTC) #4
bac
Please take a look.
10 years, 9 months ago (2013-06-24 18:13:53 UTC) #5
bac
10 years, 9 months ago (2013-06-24 19:23:54 UTC) #6
Ignore this review.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b