Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6275)

Issue 7424057: code review 7424057: go.exp/locale/cldr: Implementation of cldr package, whi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by mpvl
Modified:
11 years, 1 month ago
Reviewers:
r, mpvl
CC:
golang-dev
Visibility:
Public.

Description

go.exp/locale/cldr: Implementation of cldr package, which provides an API for accessing the XML files in the Unicode Common Locale Data Repository. It implements the various resolution mechanism, like inheritance and alias resolution. This package is to be used by the table creation tools of the various internationalization packages. A modified exp/locale/collate/maketables.go is included in this CL as an example. Note that this package is partially generated. Changes to the CLDR XML standard are expected to be backwards compatible. This is typically the case. However, care should be taken that this is indeed the case when upgrading the CLDR version. This CL also fixes several bugs in exp/locale/collate that were the result of not handling inheritance according to the CLDR specs.

Patch Set 1 #

Patch Set 2 : diff -r fdbf764ffb57 https://code.google.com/p/go.exp/ #

Patch Set 3 : diff -r fdbf764ffb57 https://code.google.com/p/go.exp/ #

Patch Set 4 : diff -r fdbf764ffb57 https://code.google.com/p/go.exp/ #

Patch Set 5 : diff -r fdbf764ffb57 https://code.google.com/p/go.exp/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+431 lines, -374 lines) Patch
locale/collate/maketables.go View 1 2 3 4 10 chunks +88 lines, -243 lines 0 comments Download
locale/collate/tools/colcmp/Makefile View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
locale/collate/tools/colcmp/chars.go View 1 2 3 4 4 chunks +342 lines, -130 lines 0 comments Download

Messages

Total messages: 5
mpvl
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.exp/
11 years, 1 month ago (2013-03-04 17:44:45 UTC) #1
r
Apologies for the delay reviewing this. I find it overwhelming. Can it be broken into ...
11 years, 1 month ago (2013-03-15 20:09:03 UTC) #2
mpvl_google.com
For starters, I've sent out a new, separate CL that only includes the tool itself ...
11 years, 1 month ago (2013-03-15 21:06:57 UTC) #3
r
thanks.
11 years, 1 month ago (2013-03-15 22:38:07 UTC) #4
mpvl
11 years, 1 month ago (2013-03-19 13:24:14 UTC) #5
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b