Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 7417043: Add Landscape bottom-bar controls

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by matthew.scott
Modified:
7 years, 8 months ago
Reviewers:
mp+150926, goodspud, gary.poster, bcsaller
Visibility:
Public.

Description

Add Landscape bottom-bar controls Landscape controls added to the bottom of environment, service, and unit views. This also involved, per UX check, moving the destroy and expose controls onthe service page to the top of the page. https://code.launchpad.net/~makyo/juju-gui/env-links-1126546/+merge/151070 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 9

Patch Set 2 : Add Landscape bottom-bar controls #

Total comments: 3

Patch Set 3 : Add Landscape bottom-bar controls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -98 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M app/assets/images/destroy_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/assets/images/slider_off.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/assets/images/slider_on.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/assets/images/tab_div.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M app/modules-debug.js View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M app/templates/landscape-controls.partial View 1 chunk +4 lines, -4 lines 0 comments Download
M app/templates/service.handlebars View 1 chunk +0 lines, -1 line 0 comments Download
M app/templates/service-footer.partial View 1 chunk +0 lines, -1 line 0 comments Download
M app/templates/service-footer-common-controls.partial View 1 chunk +4 lines, -24 lines 0 comments Download
D app/templates/service-footer-destroy-service.partial View 1 chunk +0 lines, -7 lines 0 comments Download
M app/templates/service-header.partial View 1 chunk +25 lines, -1 line 0 comments Download
A app/templates/service-header-destroy-service.partial View 1 chunk +6 lines, -0 lines 0 comments Download
M app/views/environment.js View 1 chunk +1 line, -0 lines 0 comments Download
M app/views/service.js View 1 chunk +3 lines, -0 lines 0 comments Download
A app/views/topology/landscape.js View 1 chunk +50 lines, -0 lines 0 comments Download
M app/views/topology/topology.js View 1 chunk +2 lines, -1 line 0 comments Download
M app/views/unit.js View 2 chunks +5 lines, -1 line 0 comments Download
M app/views/utils.js View 1 1 chunk +33 lines, -0 lines 0 comments Download
M lib/views/stylesheet.less View 1 2 8 chunks +51 lines, -50 lines 0 comments Download
M test/test_environment_view.js View 2 chunks +24 lines, -1 line 0 comments Download
M test/test_landscape.js View 1 2 chunks +59 lines, -4 lines 0 comments Download
M test/test_service_view.js View 2 chunks +31 lines, -0 lines 0 comments Download
M test/test_templates.js View 2 chunks +24 lines, -6 lines 0 comments Download
M test/test_unit_view.js View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 9
matthew.scott
Please take a look.
7 years, 8 months ago (2013-02-27 22:29:06 UTC) #1
gary.poster
LGTM with the addition of a few tests I mention, though I am concerned that ...
7 years, 8 months ago (2013-02-28 02:16:57 UTC) #2
bcsaller
LGTM with some suggestions below. Take it or leave it. https://codereview.appspot.com/7417043/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7417043/diff/1/app/app.js#newcode624 ...
7 years, 8 months ago (2013-02-28 15:21:25 UTC) #3
matthew.scott
Please take a look.
7 years, 8 months ago (2013-02-28 18:13:34 UTC) #4
bcsaller
LGTM I think the util method refactor came out nicely and the new test is ...
7 years, 8 months ago (2013-02-28 18:16:31 UTC) #5
matthew.scott
Thanks for the reviews. I talked with Nick this morning re: the top bar and ...
7 years, 8 months ago (2013-02-28 18:16:47 UTC) #6
gary.poster
LGTM. Thank you! gary https://codereview.appspot.com/7417043/diff/8001/test/test_landscape.js File test/test_landscape.js (right): https://codereview.appspot.com/7417043/diff/8001/test/test_landscape.js#newcode130 test/test_landscape.js:130: it('should build the bottom-bar properly', ...
7 years, 8 months ago (2013-02-28 19:16:06 UTC) #7
goodspud
LGTM Sign off from Design. Cheers!
7 years, 8 months ago (2013-03-01 15:15:48 UTC) #8
matthew.scott
7 years, 8 months ago (2013-03-01 15:26:21 UTC) #9
*** Submitted:

Add Landscape bottom-bar controls

Landscape controls added to the bottom of environment, service, and unit views. 
This also involved, per UX check, moving the destroy and expose controls onthe
service page to the top of the page.

R=gary.poster, bcsaller, goodspud
CC=
https://codereview.appspot.com/7417043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b