Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1913)

Issue 7393052: code review 7393052: cmd/vet: restructure to be package-driven (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by r
Modified:
7 years, 1 month ago
Reviewers:
CC:
golang-dev, gri, bradfitz
Visibility:
Public.

Description

cmd/vet: restructure to be package-driven This is a simple refactoring of main.go that will enable the type checker to be used during vetting. The change has an unimportant effect on the arguments: it now assumes that all files named explicitly on the command line belong to the same package. When run by the go command, this was true already. Also restore a missing parenthesis from an error message.

Patch Set 1 #

Total comments: 14

Patch Set 2 : diff -r 91778e3920ae https://code.google.com/p/go #

Total comments: 1

Patch Set 3 : diff -r 91778e3920ae https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -35 lines) Patch
M src/cmd/vet/main.go View 1 6 chunks +93 lines, -34 lines 0 comments Download
M src/cmd/vet/method.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
7 years, 1 month ago (2013-02-22 20:49:23 UTC) #1
gri
https://codereview.appspot.com/7393052/diff/1/src/cmd/vet/main.go File src/cmd/vet/main.go (right): https://codereview.appspot.com/7393052/diff/1/src/cmd/vet/main.go#newcode59 src/cmd/vet/main.go:59: fmt.Fprintf(os.Stderr, "\tvet [flags] directory...\n") # Must contain a single ...
7 years, 1 month ago (2013-02-22 21:03:34 UTC) #2
bradfitz
https://codereview.appspot.com/7393052/diff/1/src/cmd/vet/main.go File src/cmd/vet/main.go (right): https://codereview.appspot.com/7393052/diff/1/src/cmd/vet/main.go#newcode116 src/cmd/vet/main.go:116: if fi, err := os.Stat(name); err == nil && ...
7 years, 1 month ago (2013-02-22 21:03:41 UTC) #3
r
https://codereview.appspot.com/7393052/diff/1/src/cmd/vet/main.go File src/cmd/vet/main.go (right): https://codereview.appspot.com/7393052/diff/1/src/cmd/vet/main.go#newcode59 src/cmd/vet/main.go:59: fmt.Fprintf(os.Stderr, "\tvet [flags] directory...\n") not true. it is walked ...
7 years, 1 month ago (2013-02-22 21:15:39 UTC) #4
r
Hello golang-dev@googlegroups.com, gri@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
7 years, 1 month ago (2013-02-22 21:15:49 UTC) #5
gri
LGTM https://codereview.appspot.com/7393052/diff/4002/src/cmd/vet/main.go File src/cmd/vet/main.go (right): https://codereview.appspot.com/7393052/diff/4002/src/cmd/vet/main.go#newcode58 src/cmd/vet/main.go:58: fmt.Fprintf(os.Stderr, "\tvet [flags] directory...\n") i meant # Each ...
7 years, 1 month ago (2013-02-22 21:29:18 UTC) #6
r
7 years, 1 month ago (2013-02-22 21:32:48 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=e82360e6c916 ***

cmd/vet: restructure to be package-driven
This is a simple refactoring of main.go that will enable the type checker
to be used during vetting.
The change has an unimportant effect on the arguments: it now assumes
that all files named explicitly on the command line belong to the same
package. When run by the go command, this was true already.

Also restore a missing parenthesis from an error message.

R=golang-dev, gri, bradfitz
CC=golang-dev
https://codereview.appspot.com/7393052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b