Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(717)

Issue 7387053: Fix browser tests in Firefox.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by frankban
Modified:
11 years, 1 month ago
Reviewers:
teknico, mp+150780, gary.poster
Visibility:
Public.

Description

Fix browser tests in Firefox. Selenium tests now gracefully handle the "your browser is not supported" dialog. QA: Run JUJU_GUI_TEST_BROWSERS="chrome firefox" bin/test-charm All tests should pass. https://code.launchpad.net/~frankban/juju-gui/bug-1123562-browser-warning/+merge/150780 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix browser tests in Firefox. #

Patch Set 3 : Fix browser tests in Firefox. #

Patch Set 4 : Fix browser tests in Firefox. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M docs/browser-testing.rst View 1 chunk +2 lines, -0 lines 0 comments Download
M test/browser.py View 1 3 chunks +25 lines, -0 lines 0 comments Download
M test/test_charm_running.py View 4 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6
frankban
Please take a look.
11 years, 1 month ago (2013-02-27 12:39:21 UTC) #1
gary.poster
LGTM. Thank you! Gary https://codereview.appspot.com/7387053/diff/1/test/browser.py File test/browser.py (right): https://codereview.appspot.com/7387053/diff/1/test/browser.py#newcode102 test/browser.py:102: def handle_browser_warning(self): cool, I like ...
11 years, 1 month ago (2013-02-27 14:38:11 UTC) #2
teknico
LGTM. Nice code, thanks. Had an error in Chrome tests on first try but it ...
11 years, 1 month ago (2013-02-27 15:07:49 UTC) #3
frankban
Please take a look.
11 years, 1 month ago (2013-02-27 15:42:43 UTC) #4
frankban
Thanks for your reviews, Gary and Nicola. Just added an additional check in "handle_browser_warning" in ...
11 years, 1 month ago (2013-02-27 15:43:56 UTC) #5
frankban
11 years, 1 month ago (2013-02-27 16:23:31 UTC) #6
*** Submitted:

Fix browser tests in Firefox.

Selenium tests now gracefully handle the
"your browser is not supported" dialog.

QA:

Run JUJU_GUI_TEST_BROWSERS="chrome firefox" bin/test-charm
All tests should pass.

R=gary.poster, teknico
CC=
https://codereview.appspot.com/7387053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b