Get environment info from juju-core.

Get environment info from juju-core.

Implement retrieval of environment info from the juju-core API server.

Also, update the Go environment to the changes that added WebStorage
handling to the Python environment.

https://code.launchpad.net/~frankban/juju-gui/bug-1123688-environment-info/+merge/150074

(do not edit description out of merge proposal)

[frankban, 2013-02-22 15:37:14]

Please take a look.

[gary.poster, 2013-02-23 20:35:29]

LGTM, though please doublecheck that the console stuff is fine still.

If this was pair-programmed, you only need one review.

Thank you!

Gary

https://codereview.appspot.com/7382048/diff/1/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/7382048/diff/1/app/store/env/go.js#newcode112
app/store/env/go.js:112: if (credentials && credentials.areAvailable) {
Thank you both for fixing this up, and thanks to Francesco for bringing up the
underlying problem on the weekly call.

https://codereview.appspot.com/7382048/diff/1/app/store/env/go.js#newcode136
app/store/env/go.js:136: console.warn('Error retrieving environment
information.');
I thought we had some kind of problem with console calls now.  I can't remember
what it is, only that we keep removing them. :-(  If it works in devel, debug,
and prod, and the debug and prod tests pass, then it's probably fine.  The only
other potential issue I could think of would be the selenium tests.

[bcsaller, 2013-02-25 00:58:40]

https://codereview.appspot.com/7382048/diff/1/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/7382048/diff/1/app/store/env/go.js#newcode136
app/store/env/go.js:136: console.warn('Error retrieving environment
information.');
On 2013/02/23 20:35:29, gary.poster wrote:
> I thought we had some kind of problem with console calls now.  I can't
remember
> what it is, only that we keep removing them. :-(  If it works in devel, debug,
> and prod, and the debug and prod tests pass, then it's probably fine.  The
only
> other potential issue I could think of would be the selenium tests.

Complex object break the console.log impl used by phantomjs. Additionally these
logs appear during console test runs. A simple log message like this is fine.

[frankban, 2013-02-25 09:46:46]

Thanks Gary for the review you made during the weekend: very appreciated! And
thanks Ben for the clarification on the console.log issue.

[frankban, 2013-02-25 09:53:39]

*** Submitted:

Get environment info from juju-core.

Implement retrieval of environment info from the juju-core API server.

Also, update the Go environment to the changes that added WebStorage
handling to the Python environment.

R=gary.poster, bcsaller
CC=
https://codereview.appspot.com/7382048