Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(736)

Issue 7378068: Prevent commit of .only tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by bcsaller
Modified:
11 years, 1 month ago
Reviewers:
mp+150652, jeff.pihach, gary.poster
Visibility:
Public.

Description

Prevent commit of .only tests Scratching an itch around .only checkins, These only ever get committed by mistake. https://code.launchpad.net/~bcsaller/juju-gui/only-checks/+merge/150652 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Prevent commit of .only tests #

Patch Set 3 : Prevent commit of .only tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M Makefile View 2 chunks +4 lines, -1 line 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
A bin/test-filtering View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6
bcsaller
Please take a look.
11 years, 1 month ago (2013-02-26 20:05:48 UTC) #1
jeff.pihach
LGTM land with changes Great idea :-) Thanks https://codereview.appspot.com/7378068/diff/1/bin/test-filtering File bin/test-filtering (right): https://codereview.appspot.com/7378068/diff/1/bin/test-filtering#newcode5 bin/test-filtering:5: exit ...
11 years, 1 month ago (2013-02-26 20:24:02 UTC) #2
bcsaller
On 2013/02/26 20:24:02, jeff.pihach wrote: > LGTM land with changes > > Great idea :-) ...
11 years, 1 month ago (2013-02-26 20:26:55 UTC) #3
bcsaller
Please take a look.
11 years, 1 month ago (2013-02-26 20:27:37 UTC) #4
gary.poster
LGTM. Land it! :-) thanks gary
11 years, 1 month ago (2013-02-26 20:38:09 UTC) #5
bcsaller
11 years, 1 month ago (2013-02-26 20:42:18 UTC) #6
*** Submitted:

Prevent commit of .only tests

Scratching an itch around .only checkins, These only
ever get committed by mistake.

R=jeff.pihach, gary.poster
CC=
https://codereview.appspot.com/7378068
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b