Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(478)

Issue 7360043: Update css for control-unit-count input on Windows

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by rharding
Modified:
11 years, 2 months ago
Reviewers:
curtis, mp+149348
Visibility:
Public.

Description

Update css for control-unit-count input on Windows - Screenshot of change: http://uploads.mitechie.com/lp/juju_gui_unit_count_ie10b.png - Also add a note to the hacking docs that mocha-phantomjs doesn't like older versions of phamtonjs installed via .deb. https://code.launchpad.net/~rharding/juju-gui/unit_count_1111730/+merge/149348 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update css for control-unit-count input on Windows #

Patch Set 3 : Update css for control-unit-count input on Windows #

Patch Set 4 : Update css for control-unit-count input on Windows #

Patch Set 5 : Update css for control-unit-count input on Windows #

Patch Set 6 : Update css for control-unit-count input on Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M .bzrignore View 1 chunk +1 line, -1 line 0 comments Download
M HACKING View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M lib/views/stylesheet.less View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
11 years, 2 months ago (2013-02-19 17:33:29 UTC) #1
gary.poster
land as is, thank you! Please rustle up a second review from someone in Orange ...
11 years, 2 months ago (2013-02-19 17:52:51 UTC) #2
curtis
lgtm. Thank you for the CSS fix and the hacking.
11 years, 2 months ago (2013-02-19 18:19:24 UTC) #3
rharding
11 years, 2 months ago (2013-02-21 13:47:43 UTC) #4
*** Submitted:

Update css for control-unit-count input on Windows

- Screenshot of change:
  http://uploads.mitechie.com/lp/juju_gui_unit_count_ie10b.png
- Also add a note to the hacking docs that mocha-phantomjs doesn't like older
versions of phamtonjs installed via .deb.

R=gary.poster
CC=
https://codereview.appspot.com/7360043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b