Issue 7329043: code review 7329043: go.crypto/bcrypt: fix interger overflow for cost == 31

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7329043: code review 7329043: go.crypto/bcrypt: fix interger overflow for cost == 31 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by minux1

Modified:
11 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

go.crypto/bcrypt: fix interger overflow for cost == 31 Fixes issue 4803.

Patch Set 1 #

Patch Set 2 : diff -r 75e869cbf335 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 75e869cbf335 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 5338b7932892 https://code.google.com/p/go.crypto #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	bcrypt/bcrypt.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto

11 years, 2 months ago (2013-02-14 08:38:58 UTC) #1

minux1

11 years, 1 month ago (2013-02-19 11:16:50 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=983a4287662a&repo=crypto ***

go.crypto/bcrypt: fix interger overflow for cost == 31
Fixes issue 4803.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7329043

Expand All Messages | Collapse All Messages