Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(651)

Issue 7326044: code review 7326044: cmd/go: Include version information into User-Agent HTT... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by AlekSi
Modified:
10 years, 11 months ago
CC:
golang-dev
Visibility:
Public.

Description

cmd/go: Include version information into User-Agent HTTP header. `go get` now sets custom User-Agent HTTP header with Go version. It helps webmasters to distinguish 'go get' requests from other requests made by http.DefaultClient.

Patch Set 1 #

Patch Set 2 : diff -r 8c44c45a208e http://code.google.com/p/go/ #

Total comments: 2

Patch Set 3 : diff -r d58997478ec6 http://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M src/cmd/go/http.go View 1 2 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 15
AlekSi
This is the first time I use Mercurial or Rietveld. I hope I did everything ...
11 years, 1 month ago (2013-02-14 18:02:24 UTC) #1
AlekSi
Hello golang-dev@googlegroups.com, I'd like you to review this change to http://code.google.com/p/go/
11 years, 1 month ago (2013-02-14 18:18:07 UTC) #2
gburd
The Github UA requirement has no impact on 'go get' because 'go get' does not ...
11 years, 1 month ago (2013-02-14 18:22:47 UTC) #3
AlekSi
On 2013/02/14 18:22:47, gburd wrote: > The Github UA requirement has no impact on 'go ...
11 years, 1 month ago (2013-02-14 18:25:50 UTC) #4
kisielk
On 2013/02/14 18:25:50, AlekSi wrote: > On 2013/02/14 18:22:47, gburd wrote: > > The Github ...
11 years, 1 month ago (2013-02-14 20:25:28 UTC) #5
gburd
kisielk, the user agent setting in net/http does not distinguish 'go get' from other clients ...
11 years, 1 month ago (2013-02-14 20:32:52 UTC) #6
AlekSi
> Doesn't the net/http package already set the user agent to "Go http package" by ...
11 years, 1 month ago (2013-02-14 20:43:48 UTC) #7
AlekSi
Hello golang-dev@googlegroups.com, gary.burd@gmail.com, kamil.kisiel@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 1 month ago (2013-02-14 20:49:37 UTC) #8
AlekSi
Hello golang-dev@googlegroups.com, gary.burd@gmail.com, kamil.kisiel@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 1 month ago (2013-02-14 20:55:45 UTC) #9
bradfitz
https://codereview.appspot.com/7326044/diff/15001/src/cmd/go/http.go File src/cmd/go/http.go (right): https://codereview.appspot.com/7326044/diff/15001/src/cmd/go/http.go#newcode28 src/cmd/go/http.go:28: // Custom User-Agent is always useful and sometimes required. ...
11 years, 1 month ago (2013-02-14 22:08:07 UTC) #10
minux1
https://codereview.appspot.com/7326044/diff/15001/src/cmd/go/http.go File src/cmd/go/http.go (right): https://codereview.appspot.com/7326044/diff/15001/src/cmd/go/http.go#newcode29 src/cmd/go/http.go:29: var httpUserAgent = fmt.Sprintf("Go get tool (%s)", runtime.Version()) i ...
11 years, 1 month ago (2013-02-15 10:36:04 UTC) #11
bradfitz
FWIW, I don't care either way. I was just pointing out that the comment could ...
11 years, 1 month ago (2013-02-15 16:31:31 UTC) #12
AlekSi
Hello golang-dev@googlegroups.com, gary.burd@gmail.com, kamil.kisiel@gmail.com, bradfitz@golang.org, minux.ma@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 11 months ago (2013-04-08 16:42:49 UTC) #13
minux1
I still don't understand why this is necessary. Go net/http client already specifies major Go ...
10 years, 11 months ago (2013-04-08 17:00:41 UTC) #14
AlekSi
10 years, 11 months ago (2013-04-08 17:09:26 UTC) #15
Hi,

> I still don't understand why this is necessary.
> Go net/http client already specifies major Go version in the default UA
string.
> (https://codereview.appspot.com/7532043)

First version of this CL was made before one mentioned above, and I missed it.
Sorry for noise.

–-–
Alexey "AlekSi" Palazhchenko

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b