Issue 7324059: Use shared Goose client

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7324059: Use shared Goose client (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by wallyworld

Modified:
11 years, 2 months ago

Reviewers:
mp+148972

Visibility:
Public.

Description

Use shared Goose client Instead of using a separate Goose client for the Nova and Swift connections, a single shared client is used. This has been made possible due to work on the Goose side to make the client reentrant. Now only a single HTTP connection instance is used. https://code.launchpad.net/~wallyworld/juju-core/shared-goose-client/+merge/148972 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Use shared Goose client #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/openstack/local_test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/openstack/provider.go	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jameinel

LGTM, though obviously pending landing the changes to Goose.

11 years, 2 months ago (2013-02-18 09:15:38 UTC) #2

dimitern

On 2013/02/18 09:15:38, jameinel wrote: > LGTM, though obviously pending landing the changes to Goose. ...

11 years, 2 months ago (2013-02-18 10:28:55 UTC) #3

wallyworld

11 years, 2 months ago (2013-02-22 00:58:17 UTC) #4

*** Submitted:

Use shared Goose client

Instead of using a separate Goose client for the Nova and Swift connections, a
single shared
client is used. This has been made possible due to work on the Goose side to
make the client
reentrant. Now only a single HTTP connection instance is used.

R=jameinel, dimitern
CC=
https://codereview.appspot.com/7324059

Expand All Messages | Collapse All Messages