Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1307)

Issue 7313070: code review 7313070: all: cleanup C function prototypes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by ality
Modified:
11 years, 1 month ago
Reviewers:
CC:
minux1, rsc, akumar_mail.nanosouffle.net, bradfitz, golang-dev
Visibility:
Public.

Description

all: clean up C function prototypes

Patch Set 1 #

Patch Set 2 : diff -r a44171137af8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r a44171137af8 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 86c70475d48f https://code.google.com/p/go/ #

Patch Set 5 : diff -r 234c58b9499b https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -27 lines) Patch
M src/cmd/dist/windows.c View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/cmd/ld/dwarf.c View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/cmd/prof/main.c View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/lib9/main.c View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/lib9/utf/rune.c View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/lib9/windows.c View 1 1 chunk +8 lines, -4 lines 0 comments Download
M src/libmach/sym.c View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/pkg/runtime/cgo/gcc_freebsd_arm.c View 1 4 chunks +13 lines, -3 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_linux_arm.c View 1 4 chunks +13 lines, -3 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_netbsd_arm.c View 1 2 3 4 chunks +13 lines, -3 lines 0 comments Download
M src/pkg/runtime/cpuprof.c View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/pkg/runtime/race0.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/signal_freebsd_arm.c View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/pkg/runtime/signal_linux_arm.c View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/pkg/runtime/vdso_linux_amd64.c View 1 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8
ality
Hello minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2013-02-10 03:12:33 UTC) #1
minux1
LGTM if you're sure you've fixed all the problems :-)
11 years, 1 month ago (2013-02-10 17:24:34 UTC) #2
minux1
On Mon, Feb 11, 2013 at 2:27 AM, Anthony Martin <ality@pbrane.org> wrote: > > A ...
11 years, 1 month ago (2013-02-10 18:32:01 UTC) #3
akumar_mail.nanosouffle.net
By the way, semantic transformation tools can be quite useful for this type of task; ...
11 years, 1 month ago (2013-02-10 19:27:52 UTC) #4
ality
PTAL I added the changes to the new runtime/cgo/gcc_netbsd_arm.c file.
11 years, 1 month ago (2013-02-13 01:46:41 UTC) #5
minux1
LGTM.
11 years, 1 month ago (2013-02-13 16:37:20 UTC) #6
bradfitz
On Tue, Feb 19, 2013 at 5:55 PM, Anthony Martin <ality@pbrane.org> wrote: > minux <minux.ma@gmail.com> ...
11 years, 1 month ago (2013-02-20 02:26:59 UTC) #7
ality
11 years, 1 month ago (2013-02-26 17:51:42 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=646803253bb4 ***

all: clean up C function prototypes

R=minux.ma, rsc, akumar, bradfitz
CC=golang-dev
https://codereview.appspot.com/7313070
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b