Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(707)

Issue 7311094: cmd/jujuc: move jujuc functionality into jujud (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by jameinel
Modified:
11 years, 1 month ago
Reviewers:
dimitern, mp+148181, fwereade
Visibility:
Public.

Description

cmd/jujuc: move jujuc functionality into jujud The actual 'main' portion of jujuc is quite small, and the static linking nature of go means that the binary ends up fairly large. By combining the two into a single command, we can shrink the size of the tarball significantly. (4.0MB => 2.5MB, or 65% the original size.) https://code.launchpad.net/~jameinel/juju-core/only-jujud/+merge/148181 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : cmd/jujuc: move jujuc functionality into jujud #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -266 lines) Patch
M .bzrignore View 1 chunk +0 lines, -1 line 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
D cmd/jujuc/main.go View 1 chunk +0 lines, -89 lines 0 comments Download
D cmd/jujuc/main_test.go View 1 chunk +0 lines, -160 lines 0 comments Download
M cmd/jujud/agent_test.go View 1 chunk +0 lines, -1 line 0 comments Download
M cmd/jujud/main.go View 2 chunks +93 lines, -4 lines 0 comments Download
M cmd/jujud/main_test.go View 2 chunks +140 lines, -0 lines 0 comments Download
M contrib/release-public-tools/release-public-tools.sh View 1 chunk +1 line, -1 line 0 comments Download
M environs/tools.go View 1 chunk +2 lines, -2 lines 0 comments Download
M environs/tools_test.go View 1 chunk +0 lines, -3 lines 0 comments Download
M worker/uniter/tools.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/uniter/tools_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M worker/uniter/uniter_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
jameinel
Please take a look.
11 years, 1 month ago (2013-02-13 13:31:30 UTC) #1
dimitern
LGTM. Nice to have this simplification. https://codereview.appspot.com/7311094/diff/1/cmd/jujud/main_test.go File cmd/jujud/main_test.go (right): https://codereview.appspot.com/7311094/diff/1/cmd/jujud/main_test.go#newcode90 cmd/jujud/main_test.go:90: type RemoteCommand struct ...
11 years, 1 month ago (2013-02-13 14:13:54 UTC) #2
fwereade
LGTM https://codereview.appspot.com/7311094/diff/1/cmd/jujud/main_test.go File cmd/jujud/main_test.go (right): https://codereview.appspot.com/7311094/diff/1/cmd/jujud/main_test.go#newcode90 cmd/jujud/main_test.go:90: type RemoteCommand struct { On 2013/02/13 14:13:54, dimitern ...
11 years, 1 month ago (2013-02-13 19:15:35 UTC) #3
jameinel
11 years, 1 month ago (2013-02-18 13:19:10 UTC) #4
*** Submitted:

cmd/jujuc: move jujuc functionality into jujud

The actual 'main' portion of jujuc is quite small, and
the static linking nature of go means that the binary
ends up fairly large. By combining the two into a single
command, we can shrink the size of the tarball significantly.
(4.0MB => 2.5MB, or 65% the original size.)

R=dimitern, fwereade
CC=
https://codereview.appspot.com/7311094
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b