Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(114)

Issue 7310054: Cross-browser CSS tweaks

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by bac
Modified:
11 years, 1 month ago
Reviewers:
mp+146970
Visibility:
Public.

Description

Cross-browser CSS tweaks Both firefox and IE rendered the charm panel poorly for different reasons. This branch adds tweaks of a dubious nature to force them to behave. I am unhappy about the adjustment to padding-left that makes IE render the charm content in the right vertical spot. Of course by doing so it is now 6px further to the left than desired but that is much less noticeable. Reviewers might want to look at the screen shots on the bug. https://code.launchpad.net/~bac/juju-gui/1110723/+merge/146970 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Cross-browser CSS tweaks #

Patch Set 3 : Cross-browser CSS tweaks #

Patch Set 4 : Cross-browser CSS tweaks #

Patch Set 5 : Cross-browser CSS tweaks #

Patch Set 6 : Cross-browser CSS tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M app/index.html View 1 2 3 4 2 chunks +15 lines, -3 lines 0 comments Download
M lib/views/stylesheet.less View 1 5 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8
bac
Please take a look.
11 years, 1 month ago (2013-02-06 21:45:15 UTC) #1
gary.poster
Hi Brad. Thank you for doing this. The msie trick should be useful--though hatch mentioned ...
11 years, 1 month ago (2013-02-07 15:06:28 UTC) #2
hatch
https://codereview.appspot.com/7310054/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7310054/diff/1/app/app.js#newcode242 app/app.js:242: } Attaching a class like this might cause a ...
11 years, 1 month ago (2013-02-07 15:26:29 UTC) #3
matthew.scott
Thanks Brad, land with Gary's changes. Works well in FF and Chrome. https://codereview.appspot.com/7310054/diff/1/app/app.js File app/app.js ...
11 years, 1 month ago (2013-02-07 16:22:09 UTC) #4
gary.poster
Land with changes. Looked good on FF and Chrome to me
11 years, 1 month ago (2013-02-07 16:36:15 UTC) #5
bac
Please take a look.
11 years, 1 month ago (2013-02-07 19:19:31 UTC) #6
bac
Please take a look.
11 years, 1 month ago (2013-02-07 19:24:09 UTC) #7
bac
11 years, 1 month ago (2013-02-07 21:34:53 UTC) #8
*** Submitted:

Cross-browser CSS tweaks

Both firefox and IE rendered the charm panel poorly for different reasons.
This branch adds tweaks of a dubious nature to force them to behave.

I am unhappy about the adjustment to padding-left that makes IE render the
charm content in the right vertical spot.  Of course by doing so it is now 6px
further to the left than desired but that is much less noticeable.  Reviewers
might want to look at the screen shots on the bug.

R=gary.poster, hatch, matthew.scott
CC=
https://codereview.appspot.com/7310054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b