Create ghost service while configuring.

Create ghost service while configuring.

When deploying from the charm panel, a ghost service is created in the environment while the user configures the charm.  Once the charm is deployed, the service is made 'real'.  If the deploy is canceled, the ghost is removed.  If the panel is closed by a clickoutside event, the ghost remains, and clicking on it opens the panel back to the configuration pane (this allows panning, zooming, dragging, etc).  If the service is dragged, it maintains its position after being deployed.

https://code.launchpad.net/~makyo/juju-gui/service-ghost-1110715/+merge/147740

(do not edit description out of merge proposal)

[matthew.scott, 2013-02-11 18:33:49]

Please take a look.

[gary.poster, 2013-02-11 19:43:53]

Land with changes.

Really nice, Matt.  Thank you.  It works really well.  I only found a few
hiccups.

Scenario 1.
1. open charm panel
2. choose to deploy a charm (ghost appears)
3. click on a service (menu appears, charm panel disappears, ghost remains)
4. click on the ghost (charm panel reappears, ghost remains, menu remains)

I'm not sure if step 4 is wrong (the menu should disappear) or if step 3 is
wrong (the ghost should disappear).  Given logic that you've described in
discussion elsewhere, I'm guessing you would say that step 4 is wrong.

Once I started thinking about this, I noticed the following:

Scenario 1.1.
1. Click on a service to open its menu.
2. Click on the charm panel icon on the top right.

What happens is that the service menu stays open.  I kind of think it ought to
close then.  Otherwise you can click deploy and have a ghost plus a menu again.


Here's scenario 2.

1. open charm panel
2. click to deploy.  Let's say you chose "alice-irc." ghost appears with name
"(alice-irc)"
3. out of perversity, change the service name in the configuration page to be
"(alice-irc)".
4. Click "confirm".

What happens is that you get an error message that a service named "(alice-irc)"
already exists.  What should happen?  I'm not sure, but not that. :-)  I think
that the "(alice-irc)" service should be created--but what happens when you then
try to make your next ghost service for the same charm?  I bet things will fall
over then, because "(alice-irc)" is already in the database.  Ideally that
wouldn't happen either.  Any ideas on how to reconcile this?

Thank you

Gary

[matthew.scott, 2013-02-11 20:58:28]

Please take a look.

[teknico, 2013-02-12 14:27:15]

Land as is.

Very nice code, Matt, thanks.

[matthew.scott, 2013-02-12 15:03:44]

*** Submitted:

Create ghost service while configuring.

When deploying from the charm panel, a ghost service is created in the
environment while the user configures the charm.  Once the charm is deployed,
the service is made 'real'.  If the deploy is canceled, the ghost is removed. 
If the panel is closed by a clickoutside event, the ghost remains, and clicking
on it opens the panel back to the configuration pane (this allows panning,
zooming, dragging, etc).  If the service is dragged, it maintains its position
after being deployed.

R=gary.poster, teknico
CC=
https://codereview.appspot.com/7308086