Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1170)

Issue 7308068: Added GUI unit tests in the browser test suite.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by frankban
Modified:
11 years, 1 month ago
Reviewers:
mp+147356
Visibility:
Public.

Description

Added GUI unit tests in the browser test suite. Juju GUI unit tests are now included in the CI process. Also added a test exercising the environment connection. Updated the charm deployment process: "juju set" is no longer used, and the charm configuration is now provided by a temporary configuration file. To run browser tests: sudo apt-get install python-shelltoolbox python-selenium python-yaml juju bin/test-charm lp:~frankban/juju-gui/bug-1117554-gui-tests-in-browser https://code.launchpad.net/~frankban/juju-gui/bug-1117554-gui-tests-in-browser/+merge/147356 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added GUI unit tests in the browser test suite. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -28 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M bin/test-charm View 1 chunk +4 lines, -4 lines 0 comments Download
M docs/browser-testing.rst View 1 chunk +1 line, -1 line 0 comments Download
M lib/deploy_charm_for_testing.py View 3 chunks +24 lines, -4 lines 0 comments Download
M test/browser.py View 4 chunks +19 lines, -1 line 0 comments Download
M test/index.html View 1 chunk +5 lines, -2 lines 0 comments Download
M test/test_charm_running.py View 1 chunk +30 lines, -7 lines 0 comments Download
M test/test_deploy_charm_for_testing.py View 3 chunks +31 lines, -9 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
11 years, 1 month ago (2013-02-08 12:00:31 UTC) #1
gary.poster
Land as is. Really nice. Worked great for me. Thank you. Gary
11 years, 1 month ago (2013-02-08 13:44:50 UTC) #2
teknico
Land as is. Nice changes. Having difficulties running tests, for some reason. I'll keep trying. ...
11 years, 1 month ago (2013-02-08 14:09:49 UTC) #3
frankban
*** Submitted: Added GUI unit tests in the browser test suite. Juju GUI unit tests ...
11 years, 1 month ago (2013-02-08 14:19:05 UTC) #4
frankban
11 years, 1 month ago (2013-02-08 14:19:58 UTC) #5
Thanks for the reviews Gary and Nicola.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b