Issue 7308049: code review 7308049: cmd/go: fix vet

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7308049: code review 7308049: cmd/go: fix vet (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by rsc

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, minux1, fss

Visibility:
Public.

Description

cmd/go: fix vet The IgnoredGoFiles are already listed in allgofiles, so they were being run twice. Worse, the ones in IgnoredGoFiles are not fully qualified paths, so they weren't being found when executed outside the package directory. Fixes issue 4764.

Patch Set 1 #

Patch Set 2 : diff -r 36d247dd8ee5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 36d247dd8ee5 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 01baf2f3b2db https://code.google.com/p/go/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/go/vet.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 2 months ago (2013-02-05 18:20:07 UTC) #1

minux1

https://codereview.appspot.com/7308049/diff/5001/src/cmd/go/vet.go File src/cmd/go/vet.go (right): https://codereview.appspot.com/7308049/diff/5001/src/cmd/go/vet.go#newcode32 src/cmd/go/vet.go:32: // Use pkg.gofiles instead of pkg.Dir so that seems ...

11 years, 2 months ago (2013-02-05 18:24:07 UTC) #2

rsc

11 years, 2 months ago (2013-02-14 20:00:55 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=19877242dd17 ***

cmd/go: fix vet

The IgnoredGoFiles are already listed in allgofiles,
so they were being run twice. Worse, the ones in
IgnoredGoFiles are not fully qualified paths, so they
weren't being found when executed outside the
package directory.

Fixes issue 4764.

R=golang-dev, minux.ma, franciscossouza
CC=golang-dev
https://codereview.appspot.com/7308049

Expand All Messages | Collapse All Messages