Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1795)

Issue 7308045: code review 7308045: sync: add caution about where to call (*WaitGroup).Add (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by rsc
Modified:
11 years, 1 month ago
Reviewers:
CC:
DMorsing, adg, golang-dev
Visibility:
Public.

Description

sync: add caution about where to call (*WaitGroup).Add Fixes issue 4762.

Patch Set 1 #

Patch Set 2 : diff -r 36d247dd8ee5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 36d247dd8ee5 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 18067ce7e9ba https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/pkg/sync/waitgroup.go View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2013-02-05 12:19:39 UTC) #1
DMorsing
https://codereview.appspot.com/7308045/diff/1002/src/pkg/sync/waitgroup.go File src/pkg/sync/waitgroup.go (right): https://codereview.appspot.com/7308045/diff/1002/src/pkg/sync/waitgroup.go#newcode40 src/pkg/sync/waitgroup.go:40: // Note that calls with positive delta must happen ...
11 years, 1 month ago (2013-02-05 13:34:50 UTC) #2
rsc
https://codereview.appspot.com/7308045/diff/1002/src/pkg/sync/waitgroup.go File src/pkg/sync/waitgroup.go (right): https://codereview.appspot.com/7308045/diff/1002/src/pkg/sync/waitgroup.go#newcode40 src/pkg/sync/waitgroup.go:40: // Note that calls with positive delta must happen ...
11 years, 1 month ago (2013-02-09 19:45:25 UTC) #3
adg
LGTM
11 years, 1 month ago (2013-02-10 22:23:25 UTC) #4
rsc
11 years, 1 month ago (2013-02-11 13:05:51 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=940c0c10147b ***

sync: add caution about where to call (*WaitGroup).Add

Fixes issue 4762.

R=daniel.morsing, adg
CC=golang-dev
https://codereview.appspot.com/7308045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b