Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(589)

Issue 7307107: code review 7307107: cmd/ld: fix -s flag for ELF executables (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by ality
Modified:
11 years, 1 month ago
Reviewers:
CC:
rsc, minux1, dfc, golang-dev
Visibility:
Public.

Description

cmd/ld: fix -s flag for ELF executables This fixes a regression introduced in changeset 98034d036d03 which added support for producing host object files.

Patch Set 1 #

Patch Set 2 : diff -r 86c70475d48f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 86c70475d48f https://code.google.com/p/go/ #

Patch Set 4 : diff -r 86c70475d48f https://code.google.com/p/go/ #

Patch Set 5 : diff -r fdf84e3a0efe https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/cmd/ld/elf.c View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6
ality
Hello rsc@golang.org (cc: dave@cheney.net, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2013-02-13 01:35:15 UTC) #1
minux1
LGTM. Tested "go test -short -ldflags -s std", except runtime, all failed tests have something ...
11 years, 1 month ago (2013-02-13 16:57:23 UTC) #2
rsc
Did this fix anything? I can't imagine why the current code would break anything.
11 years, 1 month ago (2013-02-13 22:52:24 UTC) #3
minux1
On Thursday, February 14, 2013, Russ Cox wrote: > Did this fix anything? I can't ...
11 years, 1 month ago (2013-02-14 05:39:31 UTC) #4
rsc
LGTM Sorry, I was reading the diff as being in a different part of the ...
11 years, 1 month ago (2013-02-14 15:04:41 UTC) #5
ality
11 years, 1 month ago (2013-02-15 02:44:09 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=5ecd93cf41d4 ***

cmd/ld: fix -s flag for ELF executables

This fixes a regression introduced in changeset 98034d036d03
which added support for producing host object files.

R=rsc, minux.ma
CC=dave, golang-dev
https://codereview.appspot.com/7307107
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b