Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5546)

Issue 7307065: No outside resources for CI tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by matthew.scott
Modified:
11 years, 2 months ago
Reviewers:
mp+147194
Visibility:
Public.

Description

No outside resources for CI tests This is, for the most part, Gary's branch. It tested out well on EC2 along with the recent fix that was causing wait_on_service to blow up. https://code.launchpad.net/~makyo/juju-gui/ci-outside-resources-1116650/+merge/147194 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : No outside resources for CI tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -26 lines) Patch
M .lbox.check View 1 chunk +1 line, -1 line 0 comments Download
M Makefile View 5 chunks +4 lines, -20 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M bin/test-charm View 1 chunk +5 lines, -2 lines 0 comments Download
M docs/browser-testing.rst View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4
matthew.scott
Please take a look.
11 years, 2 months ago (2013-02-07 17:52:42 UTC) #1
gary.poster
Land as is. I figure if both of us looked at it, that ought to ...
11 years, 2 months ago (2013-02-07 18:00:22 UTC) #2
bac
looks good to land as is.
11 years, 2 months ago (2013-02-07 18:48:44 UTC) #3
matthew.scott
11 years, 2 months ago (2013-02-07 18:59:06 UTC) #4
*** Submitted:

No outside resources for CI tests

This is, for the most part, Gary's branch. It tested out well on EC2 along with
the recent fix that was causing wait_on_service to blow up.

R=gary.poster, bac
CC=
https://codereview.appspot.com/7307065
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b