Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(110)

Issue 7307051: Session management and retry improvements.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by hazmat
Modified:
11 years, 1 month ago
Reviewers:
mp+146938
Visibility:
Public.

Description

Session management and retry improvements. Lots of improvements and several bug fixes. Previously managed clientwas returning the underlying session client instead of retry, so retry wasn't enabled for uses trying to catch/store the client from connect. The retry code was using seconds for session timeout instead of milliseconds. The retry code wasn't taking account of the start of retry properly when determining max retry. The retry on persistent error wasn't signaling to the managed client to establish a new session. The client code wasn't properly cleaning up txzk handles on conn timeouts. The session establishment now uses the client session events so even without activity or active watches the session is restablished. Session restablishment will now backoff on reconnects for up to 6m. https://code.launchpad.net/~hazmat/txzookeeper/backoff-retry-managed-sanity/+merge/146938 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Session management and retry improvements. #

Patch Set 3 : Session management and retry improvements. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2168 lines, -240 lines) Patch
A .bzrignore View 1 chunk +4 lines, -0 lines 0 comments Download
A Makefile View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M debian/changelog View 1 chunk +12 lines, -0 lines 0 comments Download
M setup.py View 3 chunks +6 lines, -3 lines 0 comments Download
M txzookeeper/__init__.py View 2 chunks +5 lines, -2 lines 0 comments Download
M txzookeeper/client.py View 1 2 31 chunks +159 lines, -79 lines 0 comments Download
M txzookeeper/lock.py View 3 chunks +6 lines, -3 lines 0 comments Download
A txzookeeper/managed.py View 1 2 1 chunk +410 lines, -0 lines 0 comments Download
M txzookeeper/node.py View 1 2 4 chunks +7 lines, -26 lines 0 comments Download
M txzookeeper/queue.py View 2 chunks +5 lines, -2 lines 0 comments Download
A txzookeeper/retry.py View 1 2 1 chunk +336 lines, -0 lines 0 comments Download
M txzookeeper/tests/__init__.py View 3 chunks +58 lines, -7 lines 0 comments Download
M txzookeeper/tests/common.py View 3 chunks +27 lines, -2 lines 0 comments Download
A txzookeeper/tests/proxy.py View 1 chunk +97 lines, -0 lines 0 comments Download
M txzookeeper/tests/test_client.py View 1 2 13 chunks +63 lines, -77 lines 0 comments Download
A txzookeeper/tests/test_conn_failure.py View 1 2 1 chunk +194 lines, -0 lines 0 comments Download
M txzookeeper/tests/test_lock.py View 1 chunk +4 lines, -1 line 0 comments Download
A txzookeeper/tests/test_managed.py View 1 2 1 chunk +295 lines, -0 lines 0 comments Download
M txzookeeper/tests/test_node.py View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M txzookeeper/tests/test_queue.py View 2 chunks +5 lines, -2 lines 0 comments Download
A txzookeeper/tests/test_retry.py View 1 2 1 chunk +332 lines, -0 lines 0 comments Download
M txzookeeper/tests/test_security.py View 1 chunk +4 lines, -1 line 0 comments Download
M txzookeeper/tests/test_session.py View 1 2 10 chunks +97 lines, -19 lines 0 comments Download
M txzookeeper/tests/test_utils.py View 1 chunk +4 lines, -1 line 0 comments Download
M txzookeeper/tests/utils.py View 1 chunk +4 lines, -1 line 0 comments Download
M txzookeeper/todo.txt View 1 chunk +1 line, -9 lines 0 comments Download
M txzookeeper/utils.py View 3 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 3
hazmat
Please take a look.
11 years, 1 month ago (2013-02-06 19:27:59 UTC) #1
hazmat
Please take a look.
11 years, 1 month ago (2013-02-06 19:30:06 UTC) #2
hazmat
11 years, 1 month ago (2013-02-07 00:06:12 UTC) #3
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b