Issue 7306104: Removed getClientRect normalization method

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7306104: Removed getClientRect normalization method

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by jeff.pihach

Modified:
11 years, 2 months ago

Reviewers:
mp+148279

Visibility:
Public.

Description

Removed getClientRect normalization method The location where the getClientRect normalization method was needed was no longer required. https://code.launchpad.net/~hatch/juju-gui/1123426-getClientRect/+merge/148279 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Removed getClientRect normalization method #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -132 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
D	app/assets/javascripts/svg-layouts.js	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	app/modules-debug.js	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	app/views/environment.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	app/views/topology/service.js	View	3 chunks	+1 line, -29 lines	0 comments	Download
M	bin/merge-files	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	undocumented	View	6 chunks	+78 lines, -79 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

Land as is. Thanks! Nice clean up. Worked for me in QA with make prod. ...

11 years, 2 months ago (2013-02-13 21:17:36 UTC) #3

jeff.pihach

11 years, 2 months ago (2013-02-13 21:22:07 UTC) #4

*** Submitted:

Removed getClientRect normalization method

The location where the getClientRect normalization method was needed was no
longer required.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/7306104

Expand All Messages | Collapse All Messages