Add test for destroy service regression.

Add test for destroy service regression.

A recent change fixed a regression that occured when a service was destroyed.
The old service, which was removed from the database, was still in the
service_boxes object.  Code was added to remove services from service_boxes if
it is removed from the database.  This branch adds a unit test for that
functionality.

https://code.launchpad.net/~bac/juju-gui/test-destroy-service/+merge/148030

(do not edit description out of merge proposal)

[bac, 2013-02-12 19:17:51]

Please take a look.

[matthew.scott, 2013-02-12 19:33:10]

Land as is.  Looks good, thanks for the test!

[gary.poster, 2013-02-12 21:17:27]

Land with changes.

Good to have.  Thank you!

Gary

https://codereview.appspot.com/7306095/diff/1/test/test_environment_view.js
File test/test_environment_view.js (right):

https://codereview.appspot.com/7306095/diff/1/test/test_environment_view.js#n...
test/test_environment_view.js:942: assert.equal(existing.haproxy, 2);
why? Seems kinda silly.  If you want to highlight line 938, how about just a
comment there?

https://codereview.appspot.com/7306095/diff/1/test/test_environment_view.js#n...
test/test_environment_view.js:944: assert.equal(boxes.haproxy, undefined);
A comment about why this is desirable would not go amiss. :-)

[bac, 2013-02-12 21:30:40]

Thanks for the reviews.  Changes incorporated.

https://codereview.appspot.com/7306095/diff/1/test/test_environment_view.js
File test/test_environment_view.js (right):

https://codereview.appspot.com/7306095/diff/1/test/test_environment_view.js#n...
test/test_environment_view.js:942: assert.equal(existing.haproxy, 2);
On 2013/02/12 21:17:27, gary.poster wrote:
> why? Seems kinda silly.  If you want to highlight line 938, how about just a
> comment there?

Done.

https://codereview.appspot.com/7306095/diff/1/test/test_environment_view.js#n...
test/test_environment_view.js:944: assert.equal(boxes.haproxy, undefined);
On 2013/02/12 21:17:27, gary.poster wrote:
> A comment about why this is desirable would not go amiss. :-)

Done.

[bac, 2013-02-12 21:37:47]

*** Submitted:

Add test for destroy service regression.

A recent change fixed a regression that occured when a service was destroyed.
The old service, which was removed from the database, was still in the
service_boxes object.  Code was added to remove services from service_boxes if
it is removed from the database.  This branch adds a unit test for that
functionality.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/7306095