Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(824)

Issue 7305071: code review 7305071: spec: only require parens around ambiguous conversions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by rsc
Modified:
11 years, 1 month ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

spec: only require parens around ambiguous conversions This is documenting the status quo. The previous cleanup added this language as an implementation restriction, but at least for now it is really part of the language proper. Fixes issue 4605.

Patch Set 1 #

Patch Set 2 : diff -r e8eb2c8d5ce1 https://code.google.com/p/go/ #

Patch Set 3 : diff -r e8eb2c8d5ce1 https://code.google.com/p/go/ #

Patch Set 4 : diff -r e8eb2c8d5ce1 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 5 : diff -r a44171137af8 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 2044cd3dc3b4 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M doc/go_spec.html View 1 2 3 4 5 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2013-02-09 19:11:21 UTC) #1
r
https://codereview.appspot.com/7305071/diff/5001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/7305071/diff/5001/doc/go_spec.html#newcode3451 doc/go_spec.html:3451: necessary to avoid ambiguity: include an example where it's ...
11 years, 1 month ago (2013-02-09 21:17:10 UTC) #2
rsc
PTAL
11 years, 1 month ago (2013-02-09 22:59:15 UTC) #3
r
LGTM
11 years, 1 month ago (2013-02-10 03:47:08 UTC) #4
rsc
11 years, 1 month ago (2013-02-11 12:48:20 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=18067ce7e9ba ***

spec: only require parens around ambiguous conversions

This is documenting the status quo. The previous cleanup
added this language as an implementation restriction, but
at least for now it is really part of the language proper.

Fixes issue 4605.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7305071
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b