Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 7301076: Fix run_until_complete (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by saghul
Modified:
8 years, 2 months ago
Reviewers:
gvrpython, GvR
Visibility:
Public.

Description

Additional related tests in this previous review: https://codereview.appspot.com/7312046/

Patch Set 1 #

Total comments: 7

Patch Set 2 : Fix run_until_complete #

Total comments: 3

Patch Set 3 : Fixed run_until_complete #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -8 lines) Patch
M tulip/base_events.py View 1 2 2 chunks +13 lines, -8 lines 0 comments Download
M tulip/tasks_test.py View 1 2 3 chunks +27 lines, -0 lines 1 comment Download

Messages

Total messages: 6
GvR
https://codereview.appspot.com/7301076/diff/1/tulip/base_events.py File tulip/base_events.py (right): https://codereview.appspot.com/7301076/diff/1/tulip/base_events.py#newcode97 tulip/base_events.py:97: def _stop(): No need to name it with an ...
8 years, 2 months ago (2013-02-11 21:35:11 UTC) #1
saghul
I (hopefully) addressed all your comments on patch set 2.
8 years, 2 months ago (2013-02-11 21:54:04 UTC) #2
GvR
See also my musings on python-ideas about the proper return value of run_until_complete()... https://codereview.appspot.com/7301076/diff/5001/tulip/tasks_test.py File ...
8 years, 2 months ago (2013-02-11 22:27:45 UTC) #3
saghul
Updated addressing the comments above and those on the mailing list, if the loop is ...
8 years, 2 months ago (2013-02-11 22:40:04 UTC) #4
GvR
LGTM -- you can just fix the one nit below and submit. Thanks!! https://codereview.appspot.com/7301076/diff/7002/tulip/tasks_test.py File ...
8 years, 2 months ago (2013-02-11 22:57:35 UTC) #5
saghul
8 years, 2 months ago (2013-02-11 23:03:20 UTC) #6
On 2013/02/11 22:57:35, GvR wrote:
> LGTM -- you can just fix the one nit below and submit. Thanks!!
> 
> https://codereview.appspot.com/7301076/diff/7002/tulip/tasks_test.py
> File tulip/tasks_test.py (right):
> 
>
https://codereview.appspot.com/7301076/diff/7002/tulip/tasks_test.py#newcode152
> tulip/tasks_test.py:152: self.assertTrue(0.2 <= t1-t0 <= 0.5)
> Shouldn't this be 0.18 <= t1-t0 <= 0.22?

Committed in 7ec755b2196b, I also fixed the timeout check, Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b