Issue 7301073: testing/charms: Remove the series parameter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7301073: testing/charms: Remove the series parameter (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by jameinel

Modified:
11 years, 1 month ago

Reviewers:
mp+147598

Visibility:
Public.

Description

testing/charms: Remove the series parameter This change removes some of the symlinks in the working tree (testing/repo/*). Following on to it, there were a bunch of apis in testing.Charms that took a series parameter, but all callers were just passing "series" anyway. All the tests still pass, so I'm pretty happy with the changes. https://code.launchpad.net/~jameinel/juju-core/no-symlinks/+merge/147598 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : testing/charms: Remove the series parameter #

Patch Set 3 : testing/charms: Remove the series parameter #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	charm/bundle_test.go	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimitern

On 2013/02/11 07:04:57, jameinel wrote: > Please take a look. I replied to the MP ...

11 years, 2 months ago (2013-02-12 08:11:24 UTC) #2

jameinel

*** Submitted: testing/charms: Remove the series parameter This change removes some of the symlinks in ...

11 years, 2 months ago (2013-02-13 12:39:03 UTC) #4

jameinel

11 years, 2 months ago (2013-02-18 12:31:45 UTC) #5

*** Submitted:

testing/charms: Remove the series parameter

This change removes some of the symlinks in the working tree (testing/repo/*).
Following on to it, there were a bunch of apis in testing.Charms that took a
series parameter, but all callers were just passing "series" anyway.

All the tests still pass, so I'm pretty happy with the changes.

R=
CC=
https://codereview.appspot.com/7301073

Expand All Messages | Collapse All Messages