Issue 7300100: code review 7300100: cmd/vet: drop column information from error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7300100: code review 7300100: cmd/vet: drop column information from error (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by rsc

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, dsymonds, r

Visibility:
Public.

Description

cmd/vet: drop column information from error The column information can be misleading.

Patch Set 2 : diff -r 140452485d03 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 140452485d03 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 3298d36afcd6 https://code.google.com/p/go/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	src/cmd/vet/main.go	View	1 2 3	1 chunk	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 2 months ago (2013-02-13 03:33:45 UTC) #1

dsymonds

LGTM https://codereview.appspot.com/7300100/diff/4001/src/cmd/vet/main.go File src/cmd/vet/main.go (right): https://codereview.appspot.com/7300100/diff/4001/src/cmd/vet/main.go#newcode206 src/cmd/vet/main.go:206: loc := f.loc(pos) I'd probably inline this into ...

11 years, 2 months ago (2013-02-13 03:36:10 UTC) #2

LGTM https://codereview.appspot.com/7300100/diff/4001/src/cmd/vet/main.go File src/cmd/vet/main.go (right): https://codereview.appspot.com/7300100/diff/4001/src/cmd/vet/main.go#newcode199 src/cmd/vet/main.go:199: // Do not print column: it's too exact. ...

11 years, 2 months ago (2013-02-13 05:07:40 UTC) #3

rsc

11 years, 2 months ago (2013-02-14 03:34:43 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=31065f4dbca5 ***

cmd/vet: drop column information from error

The column information can be misleading.

R=golang-dev, dsymonds, r
CC=golang-dev
https://codereview.appspot.com/7300100

Expand All Messages | Collapse All Messages