Issue 7241058: Implement nagios support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7241058: Implement nagios support

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by abentley-home

Modified:
11 years, 2 months ago

Reviewers:
mp+145970, rharding

Visibility:
Public.

Description

Implement nagios support Change the way errors are reported so that any errors running ingest cause a file, ~ubuntu/var/ingest-errors, to be created. The presence of this file is used for a nagios check. The files in charmsupport are copied almost verbatim from lp:charmsupport r27. (Exception, the change in lp:~pjdc/charmsupport/hookenv-vs-nrpe was applied.) Ideally we will switch to a packaged version of charmsupport, but not if its nagios support is broken! The shhh.py file is deleted because it is no longer needed. https://code.launchpad.net/~abentley/charms/precise/charmworld/nagios/+merge/145970 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+376 lines, -83 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	charmsupport/__init__.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	charmsupport/hookenv.py	View	1 chunk	+150 lines, -0 lines	0 comments	Download
A	charmsupport/nrpe.py	View	1 chunk	+169 lines, -0 lines	0 comments	Download
M	config.yaml	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	files/nrpe-external-master/check_ingest.sh	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	hooks/config-changed	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	hooks/install	View	1 chunk	+1 line, -1 line	0 comments	Download
A	hooks/nrpe-external-master-relation-changed	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	hooks/upgrade-charm	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	metadata.yaml	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	revision	View	1 chunk	+1 line, -1 line	0 comments	Download
A	run-write-errors	View	1 chunk	+16 lines, -0 lines	0 comments	Download
D	shhh.py	View	1 chunk	+0 lines, -81 lines	0 comments	Download
A	update-nrpe.py	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rharding

11 years, 2 months ago (2013-01-31 20:27:24 UTC) #2

lgtm but I'd like to move the new files into a scripts directory. I've started
one in my branch as well. Things like the run-write-errors and update-nrpe.py
could find a home there and help prevent polluting the root of the file tree.

Expand All Messages | Collapse All Messages