Add simple test for dragend workaround.

Add simple test for dragend workaround.

The work-around added to the build relation 'dragend' event handler to prevent
the serviceClick handler from processing and doing the wrong thing is now
tested.  An integration test using simulated drags and a click on the service
didn't prove feasible so this unit test is used.

https://code.launchpad.net/~bac/juju-gui/dragend-workaround-test/+merge/145400

(do not edit description out of merge proposal)

[bac, 2013-01-29 15:28:14]

Please take a look.

[benji, 2013-01-29 17:45:50]

Looks good.  I added a couple of comments.

https://codereview.appspot.com/7237053/diff/1/test/test_service_module.js
File test/test_service_module.js (right):

https://codereview.appspot.com/7237053/diff/1/test/test_service_module.js#new...
test/test_service_module.js:81: it('should ', function() {});
I'm all for lots of tests, but this may be going too far. ;P

https://codereview.appspot.com/7237053/diff/1/test/test_service_module.js#new...
test/test_service_module.js:258: assert.isFalse(topo.ignoreServiceClick);
A comment about why this is false would be good.  I assume it is because the
ignore-er resets the ignoreServiceClick flag.

[bac, 2013-01-29 17:50:35]

Please take a look.

[gary.poster, 2013-01-29 18:55:54]

Land as is, or with trivial changes.

Thank you!

Gary

https://codereview.appspot.com/7237053/diff/6/test/test_service_module.js
File test/test_service_module.js (right):

https://codereview.appspot.com/7237053/diff/6/test/test_service_module.js#new...
test/test_service_module.js:239: // unobvious.
Instead of the "A better test..." sentence, maybe say that we hope to also test
this via Selenium?  For a unit test, this approach looks hunky dory to me.

[bac, 2013-01-29 19:00:24]

Thanks for the improvements.

[bac, 2013-01-29 19:13:27]

*** Submitted:

Add simple test for dragend workaround.

The work-around added to the build relation 'dragend' event handler to prevent
the serviceClick handler from processing and doing the wrong thing is now
tested.  An integration test using simulated drags and a click on the service
didn't prove feasible so this unit test is used.

R=benji, gary.poster
CC=
https://codereview.appspot.com/7237053