Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(435)

Issue 7237044: Remove the unused "units" option. Added tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by frankban
Modified:
11 years, 2 months ago
Reviewers:
mp+145156
Visibility:
Public.

Description

Remove the unused "units" option. Added tests. This branch removes the disconnected "units" voice from the service menu. Also added some tests for the service module, and fixed test dependencies so that now the service module events tests can be run in isolation. https://code.launchpad.net/~frankban/juju-gui/bug-1107652-remove-units/+merge/145156 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 9

Patch Set 2 : Remove the unused "units" option. Added tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -30 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/templates/overview.handlebars View 1 chunk +0 lines, -1 line 0 comments Download
M app/views/topology/service.js View 3 chunks +10 lines, -10 lines 0 comments Download
M lib/views/stylesheet.less View 1 chunk +0 lines, -3 lines 0 comments Download
M test/test_service_module.js View 1 4 chunks +56 lines, -16 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
11 years, 2 months ago (2013-01-28 11:29:32 UTC) #1
teknico
Land with changes. Thanks, nice. Just the same name change in three places, nothing substantial. ...
11 years, 2 months ago (2013-01-28 12:09:52 UTC) #2
bac
Land with Nicola's changes. Thanks! https://codereview.appspot.com/7237044/diff/1/test/test_service_module.js File test/test_service_module.js (right): https://codereview.appspot.com/7237044/diff/1/test/test_service_module.js#newcode186 test/test_service_module.js:186: // Click the "View" ...
11 years, 2 months ago (2013-01-28 12:18:26 UTC) #3
frankban
11 years, 2 months ago (2013-01-28 12:33:39 UTC) #4
*** Submitted:

Remove the unused "units" option. Added tests.

This branch removes the disconnected "units" voice
from the service menu.

Also added some tests for the service module, and
fixed test dependencies so that now the service 
module events tests can be run in isolation.

R=teknico, bac
CC=
https://codereview.appspot.com/7237044

https://codereview.appspot.com/7237044/diff/1/test/test_service_module.js
File test/test_service_module.js (right):

https://codereview.appspot.com/7237044/diff/1/test/test_service_module.js#new...
test/test_service_module.js:184: it('hides the service menu when the View voice
is clicked', function() {
On 2013/01/28 12:09:53, teknico wrote:
> I think you want "...the View entry...".

Done.

https://codereview.appspot.com/7237044/diff/1/test/test_service_module.js#new...
test/test_service_module.js:186: // Click the "View" menu voice.
On 2013/01/28 12:18:26, bac wrote:
> And here...

Done.

https://codereview.appspot.com/7237044/diff/1/test/test_service_module.js#new...
test/test_service_module.js:191: it('hides the service menu when the Destroy
voice is clicked', function() {
On 2013/01/28 12:09:53, teknico wrote:
> Ditto, s/voice/entry/.

Done.

https://codereview.appspot.com/7237044/diff/1/test/test_service_module.js#new...
test/test_service_module.js:218: // Click the "Destroy" menu voice.
On 2013/01/28 12:09:53, teknico wrote:
> Ditto, s/voice/entry/.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b